Looks like there were still some API changes that needed to be made. I started making a list and then just figured I'd chip in and help.

The result is a rather large patch. I myself dislike reviewing large patches so I won't be at all offended if the patch isn't applied. It can sometimes take longer to review the patch than to just recreate the changes, especially if there are changes you don't want or would rather do differently. With that in mind I kept track of the refactors so if you wanted to go that route it would be a little easier.

Here's the list of refactors:

API CLASS RENAMES

@InterceptorBindingType -> @InterceptorBinding
Notify -> Reception

API METHOD RENAMES

Bean
  - getBindingTypes() -> getQualifiers()
  - getScopeTypes() -> getScopes()

Context
  - getScopeType() -> getScope()

BeanManager
  - isInterceptorBindingType() -> isInterceptorBinding()
- getInterceptorBindingTypeDefinition() -> getInterceptorBindingDefinition()

BeforeBeanDiscovery
  - addBindingType() -> addQualifier()
  - addInterceptorBindingType() -> addInterceptorBindingType()

Decorator
  - getDelegateBindingTypes() -> getDelegateQualifiers()

InjectionPoint
  - getBindingTypes() -> getQualifiers()

Interceptor
  - getInterceptorBindingTypes() - getInterceptorBindings()

ObserverMethod
  - getObservedBindings() -> getObservedQualifiers()
  - getNotify() -> getReception()

API RELATED EXCEPTION TEXT

@ScopeType in text -> @Scope
@BindingType in text -> @Qualifier
@InterceptorBindingType in text -> @InterceptorBinding

INTERNAL METHOD RENAMES (ALL OPTIONAL)

AbstractBean
  - getImplBindingTypes -> getImplQualifiers()
  - addBindingType() -> addQualifier()

BeanCreator
  - defineBindingType() -> defineQualifier()

DefinitionUtil
  - defineBindingTypes() -> defineQualifiers()

AnnotationUtil
  - isBindingAnnotation() -> isQualifierAnnotation()
  - getBindingAnnotation() -> getQualifierAnnotations()
- getMethodFirstParameterBindingTypesWithGivenAnnotation() -> getMethodFirstParameterQualifierWithGivenAnnotation()
  - checkBindingTypeConditions() -> checkQualifierConditions()
  - isAnyBindingExist() -> isAnyQualifierExist()

IBeanInheritedMetaData
  - getInheritedBindingTypes() -> getInheritedQualifiers()
- getInheritedInterceptorBindingTypes() -> getInheritedInterceptorBindings()

InstanceImpl
  - getAdditionalBindings() -> getAdditionalQualifiers()

ObserverWrapper
  - getEventBindingTypes() -> getEventQualifiers()
  - isObserverOfBindings() -> isObserverOfQualifiers()

WebBeansInterceptor
  - addInterceptorBindingType() -> addInterceptorBinding()
  - isBindingTypesExist() -> isBindingExist()

WebBeansUtil
- checkForNewBindingForDeployment() -> checkForNewQualifierForDeployment()


I attempted to update all relating parameter names, variable names and javadoc was updated as well.

Patch available here:  https://issues.apache.org/jira/browse/OWB-134


-David

Reply via email to