Hey Mark; In the BeanObserverImpl#notify method, you removed conditional exception throwing. But spec. specifies that in "10.5 Observer notification" that "you must catch and log all transactional exceptions and throw other exceptions as Runtime exception."
You can see SVN difference here: http://svn.apache.org/viewvc/incubator/openwebbeans/trunk/webbeans-impl/src/main/java/org/apache/webbeans/event/BeanObserverImpl.java?p2=%2Fincubator%2Fopenwebbeans%2Ftrunk%2Fwebbeans-impl%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fwebbeans%2Fevent%2FBeanObserverImpl.java&p1=%2Fincubator%2Fopenwebbeans%2Ftrunk%2Fwebbeans-impl%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fwebbeans%2Fevent%2FBeanObserverImpl.java&r1=824190&r2=824189&view=diff&pathrev=824190 Besides this, what are the TODOs that you have mentioned? Could you run TCK event tests over our event implementation? Thanks; -Gurkan 2009/10/12 Mark Struberg (JIRA) <[email protected]> > > [ > https://issues.apache.org/jira/browse/OWB-140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12764517#action_12764517] > > Mark Struberg commented on OWB-140: > ----------------------------------- > > only partly fixed! > > I removed the Observer and a few other classes which are not in the JSR-299 > spec anymore, but there are still a few TODOs. > > All tests succeed though - so I think we simply miss a few tests ;) > > > Remove javax.enterprise.event.Observer > > -------------------------------------- > > > > Key: OWB-140 > > URL: https://issues.apache.org/jira/browse/OWB-140 > > Project: OpenWebBeans > > Issue Type: Sub-task > > Components: Core, Events > > Affects Versions: M3 > > Reporter: David Blevins > > Assignee: Gurkan Erdogdu > > Fix For: M4 > > > > > > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > > -- Gurkan Erdogdu http://gurkanerdogdu.blogspot.com
