>>>ad 1) I moved the OpenEJB.init() to StandaloneContainersImpl#setup() so this >>>initialisation will only be performed if It is not necessary to call OpenEJB.init in standalone mode. We do not provide EJB functionality in standalone mode. It works only in container mode.
>>>ad 2)Still it is not really clear to me how the TCK suite works on your >>>computer. Will look at again. >>>For the unpacking vs dependency: the only thing which matters is if the jars >>>are on the classpath Ok, then, current way for doing that is fine. ________________________________ From: Mark Struberg <[email protected]> To: [email protected] Sent: Tue, December 1, 2009 12:13:57 AM Subject: Re: tons of skipped TCK tests Thanks Gurkan! It's still not really clear to me, so maybe I should try to sum it up again: ad 1) I moved the OpenEJB.init() to StandaloneContainersImpl#setup() so this initialisation will only be performed if we dont test against tomcat. It simply doesn't work here after a clean checkout. Do you have JBossAS in your classpath? Maybe I oversee something... ad 2) Still it is not really clear to me how the TCK suite works on your computer. With a standard tomcat-6.0.18 I experienced exactly the same DeploymentException (and thus skipped tests) as when running in a standalone mode. The few Exceptions I fixed yesterday (package scope constructor) have nothing to do with EJB at all. And they aborted almost all the TCK tests. Can you please try to clean your .m2/repository? Maybe we face some artifact clash? For the unpacking vs dependency: the only thing which matters is if the jars are on the classpath. This is the case in both ways. The only subtle difference is if we would like to apply some kind of byte code enhancement (which we don't do). LieGrue, strub --- Gurkan Erdogdu <[email protected]> schrieb am Mo, 30.11.2009: > Von: Gurkan Erdogdu <[email protected]> > Betreff: Re: tons of skipped TCK tests > An: [email protected] > Datum: Montag, 30. November 2009, 18:22 > For question 1 : > OpenEJB is used with Apache Tomcat as an embeddable. It is > not enabled as default. If you deploy WAR archive that > contains EJB classes, EJBs are deployed by the OpenEJB > before "contextInitialized()" is called. We configure > OWB in "contextInitialized" so we can get that which class > is EJB or not. There is no start-up logic beyon this. > > For question 2 : > We must run TCK in embeddable OpenEJB in Tomcat. So > dependency:copy adds all necessary jar into each test WAR > archive "lib" folder. I do not see any skipped test in my > environment. Maybe your Tomcat configuration is wrong. > > --Gurkan > > > > > ________________________________ > From: Mark Struberg <[email protected]> > To: [email protected] > Sent: Sat, November 28, 2009 11:27:02 AM > Subject: tons of skipped TCK tests > > Hi! > > I'm playing around with the TCK suite for a few days and > almost all tests got skipped. I tried this with tomcat and > also as standalone, and both give similar results. > > Let's stick with the standalone container for now: > > 1.) The webbeans-ejb plugin (which we should rename to > webbeans-openejb imho, because it uses a lot internal > OpenEJB functionality) doesn't get startet up correctly. I > fixed that part in the PluginLoader and added a starup logic > to the EJBPlugin. I'm not sure about this part since OpenEJB > should already be started up, isn't? In the TCK it isn't so > I got a NullPointerException because > SystemInstance.get().getComponent(ContainerSystem.class); > returned null. > > We should sum up in which scenarios OpenEJB gets started up > at which point in time/bootstrapped from which component. > > 2.) I'm not sure why all the dependencies got copied over > with dependency:copy instead of simply setting the test > dependencies? Imho the only thing we have to dependency:copy > are those parts which are accessed via a file path instead > of getting it via the classloader (afaik only the > testng-suite.xml) > > Oki, that should be it for now ;) > > I'll continue to figure out why most of the TCK tests get > skipped. > > LieGrue, > strub > > __________________________________________________ > Do You Yahoo!? > Sie sind Spam leid? Yahoo! Mail verfügt über einen > herausragenden Schutz gegen Massenmails. > http://mail.yahoo.com > > > > __________________________________________________ Do You Yahoo!? Sie sind Spam leid? Yahoo! Mail verfügt über einen herausragenden Schutz gegen Massenmails. http://mail.yahoo.com
