Hello,

I'm experimenting with the development version of Ruote (primary because I'd
love to give you a feedback about the new "temporary fields feature") and I
just noticed a compatibility break with Ruote 2.2.0.

This is the diff.
https://github.com/jmettraux/ruote/compare/v2.2.0...master#diff-39

I have the following piece of code

    class MyClass
      def by_user(user)
        list = $engine.storage_participant.select do |workitem|
          workitem.target_includes?(user)
        end
        list.map { |w| new(w) }
      end
    end

It worked with Ruote 2.2.0 but now it raises the error

     NoMethodError:
       protected method `select' called for
#<Ruote::StorageParticipant:0x105251da8>

because you defined a new #select method on the StorageParticipant class.
This method overrides the default enumerable#select method and it also
changes the method API.
Is it intentional?

Also, I noticed you changed the fetch_all API and the parameter is no longer
optional. It doesn't really affect my code but I believe this change make
some methods incoherent with others, like for example the #all(opt = {})
method.
https://github.com/jmettraux/ruote/compare/v2.2.0...master#L39L156

Just my 2 cents. ;)


-- 
Simone Carletti
Application Developer

Site & Blog: http://www.simonecarletti.com
Email: [email protected]
LinkedIn: http://linkedin.com/in/weppos
Skype: weppos

-- 
you received this message because you are subscribed to the "ruote users" group.
to post : send email to [email protected]
to unsubscribe : send email to [email protected]
more options : http://groups.google.com/group/openwferu-users?hl=en

Reply via email to