Hello List,

I just saw an interesting commit at

  https://github.com/xaop/ruote/commit/8ca1662ae23bc8f2f836f1fd3fc6dabfe74ffc4c

Julien has a point, 'union', most of the time, evokes union of sets, so he 
removed duplicates from merged array.

Now I think the extra parameter 'uniq_on_union_array' is a bit long. I'd 
suggest splitting 'union' into 'union' and 'concat', where 'union' is the 
default as seen by Julien (uniq! applied) and 'concat' reproduces the current 
behaviour (pre-Julien).

The commit misses a test for :uniq_on_union_array => false.


Wdyt ?

--
John Mettraux - http://jmettraux.wordpress.com

-- 
you received this message because you are subscribed to the "ruote users" group.
to post : send email to [email protected]
to unsubscribe : send email to [email protected]
more options : http://groups.google.com/group/openwferu-users?hl=en

Reply via email to