Great! There's a django validation that forbids adding an invalid JSON into the database, but probably when the page is reloaded with the validation error shown, the editor doesn't load as you say, but haven't tried it. Could you send a link of your PR to JSONEditor?
Federico On Sunday, March 5, 2017 at 11:14:09 PM UTC+1, GASTON CHE wrote: > > I am proposing a fix to this issue. I already submitted a PR for the > addition of an advanced JSONEditor, which validates the validity of the > JSON entered as well as validates the JSON against the schema provided for > the configuration. Adding pre-validation to for the various pages that > require advanced JSON editing, will not be difficult as the editor already > validates the JSON. > > On Sunday, 5 March 2017 23:06:37 UTC+1, GASTON CHE wrote: >> >> This error also causes the advanced mode editor not to be able to load >> while trying to edit an existing configuration which was submitted with >> invalid json. Adding a graphical JSONEditor for advanced json editing while >> display json errors properly to the admin while editing configs, but this >> will not prevent the user from submitting the invalid json. I prevent that >> inorder to solve the issue >> https://github.com/openwisp/django-netjsonconfig/issues/30, there should >> be prevalidation of the json to make sure it is valid before it is even >> submitted, that way, invalid json never get stored. >> > -- You received this message because you are subscribed to the Google Groups "OpenWISP" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
