I have not yet pushed the work, but, i have followed the documentation on the json editor and have used the theme option, and included the files required to no avail. I will be pushing the changes i have done that fix all the other problems while continueing to try and find a way around the theme problem . i have created an issue, on the jsonEditor repo and hope to get some help soon
On 7 March 2017 at 07:08, Federico Capoano <[email protected]> wrote: > Hi Gaston, > > I understand is not trivial to perform all the requested changes, let's > see what we can do right now to merge this. > > I have two questions: > > 1. I cannot see your fixes to the PR (last commit is from yesterday), have > you pushed them already? > > 2. on the JSONEditor docs > <https://github.com/josdejong/jsoneditor/blob/master/docs/api.md> I've > seen there's a "theme" option, it says: > > {String} theme >> Set the Ace editor theme, uses included 'ace/theme/jsoneditor' by >> default. Please note that only the default theme is included with >> jsoneditor, so if you specify another one you need to make sure it is >> loaded. > > > Could you try to add the files of the theme and put the theme name into > that option and see if it works? > > Once merged, I will release it so our community can start using this new > feature straightaway. Keep us posted! > > Federico > > > On Tuesday, March 7, 2017 at 1:17:33 PM UTC+1, GASTON CHE wrote: >> >> I have fixed the issues you pointed out on mu PR, but as it stands, the >> JSONEditor tool does not really have a geat API for using new ACE themes >> with it so it's tough to intergrate the tommorow niight bright theme into >> it. >> >> On Monday, 6 March 2017 16:00:00 UTC+1, Federico Capoano wrote: >>> >>> I've tested the patch, the new widget for the advanced mode looks great! >>> There are a few issues that came out while testing it with a friend. I left >>> a review here: https://github.com/openwisp/django-netjsonconfig/pull/ >>> 40#issuecomment-284418748 >>> >>> Fed >>> >>> >>> On Monday, March 6, 2017 at 2:18:17 PM UTC+1, Federico Capoano wrote: >>>> >>>> That's bad luck. Anyway, keep trying until you solve the issues. If you >>>> get stuck, let me know and I'll help you as soon as I have some free time. >>>> >>>> Federico >>>> >>>> >>>> On Monday, March 6, 2017 at 1:27:31 PM UTC+1, GASTON CHE wrote: >>>>> >>>>> I normally develop using Ubuntu Linux and have been using it for over >>>>> 3 years now, but my computer got stolen so i am currently using a >>>>> temporary >>>>> computer for development until i am able to get a new laptop. I have tried >>>>> to setup the project on Kali Linux available on the computer i am >>>>> currently >>>>> using, but i keep getting errors about module setuptools not found from >>>>> the setup.py file >>>>> >>>>> On Monday, 6 March 2017 03:11:15 UTC-6, Federico Capoano wrote: >>>>>> >>>>>> I see here: https://github.com/openwisp/django-netjsonconfig/pull/ >>>>>> 40/files >>>>>> >>>>>> runflake8 100755 → 100644 >>>>>> runisort 100755 → 100644 >>>>>> runtests.py 100755 → 100644 >>>>>> tests/manage.py 100755 → 100644 >>>>>> >>>>>> You (or WINDOWS) inadvertently changed the permissions of certain >>>>>> files (git stores unix permissions too and those can be changed in the >>>>>> repo). >>>>>> The changes to those files should be reverted and you should find a >>>>>> way to avoid changing those permissions, otherwise the build will fail. >>>>>> Applying sudo: false on travis is not a good solution, because we >>>>>> need to use sudo: true in order to activate the docker-based >>>>>> infrastructure >>>>>> of travis-ci which runs MUCH faster. >>>>>> >>>>>> I'm going to review your pull request on github and help you to fix >>>>>> these issues. >>>>>> >>>>>> PS: you seem like a good developer, have you thought about learning >>>>>> to use unix/linux? I was like you 10 years go and since I've started >>>>>> learning linux I improved dramatically! >>>>>> >>>>>> >>>>>> On Sunday, March 5, 2017 at 8:38:24 PM UTC+1, GASTON CHE wrote: >>>>>>> >>>>>>> I have run the script locally and fixed all errors that it was >>>>>>> giving but when create a PR i still get errors with the flake8, >>>>>>> looking at >>>>>>> the logs i see that's it's an issue with permisions, >>>>>>> /home/travis/build.sh: line 62: ./runflake8: Permission denied >>>>>>> >>>>>>> >>>>>>> >>>>>>> On Sunday, 5 March 2017 18:01:30 UTC+1, Federico Capoano wrote: >>>>>>>> >>>>>>>> Ok, I didn't know you were using windows. Run flake8 manually (copy >>>>>>>> the command in the runflake8 script contained in the repo). >>>>>>>> >>>>>>>> Fed >>>>>>>> >>>>>>>> Il dom 5 mar 2017, 15:27 GASTON CHE <[email protected]> ha scritto: >>>>>>>> >>>>>>>>> I am working in windows 8 and i setup my environtment following >>>>>>>>> following the instrucstions on the repo. How do i run it on windows >>>>>>>>> because >>>>>>>>> trying to run it with python on cmd on windows gives the error, even >>>>>>>>> when >>>>>>>>> running the cmd in administrator mode. >>>>>>>>> unable to create process using bi/bash runflake8 >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> On Sunday, 5 March 2017 13:51:06 UTC+1, GASTON CHE wrote: >>>>>>>>> >>>>>>>>>> I have made fixes pertaining to issue #30 on the >>>>>>>>>> django-netjsonconfig repo on gihub, nad i am trying to create a PR, >>>>>>>>>> but >>>>>>>>>> once I create the request, the travic-CI checks >>>>>>>>>> ,https://travis-ci.org/openwisp/django-netjsonconfig/builds/ >>>>>>>>>> 207710200 >>>>>>>>>> <https://travis-ci.org/openwisp/django-netjsonconfig/builds/207710200>, >>>>>>>>>> fail. when looking at the logs of the build I notice the error is >>>>>>>>>> coming >>>>>>>>>> from the ./runflake8 specified in the .travis.yml. I have not modied >>>>>>>>>> the >>>>>>>>>> travis yml file neither have i changed the runflake8 file in any >>>>>>>>>> way. So i >>>>>>>>>> don't know how to fix this, so the build checks can be successfull. >>>>>>>>>> I would like some help here >>>>>>>>>> >>>>>>>>> -- >>>>>>>>> You received this message because you are subscribed to the Google >>>>>>>>> Groups "OpenWISP" group. >>>>>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>>>>> send an email to [email protected]. >>>>>>>>> For more options, visit https://groups.google.com/d/optout. >>>>>>>>> >>>>>>>> -- > You received this message because you are subscribed to a topic in the > Google Groups "OpenWISP" group. > To unsubscribe from this topic, visit https://groups.google.com/d/ > topic/openwisp/Fq1Y5vLpYgQ/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "OpenWISP" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
