Great progress! I've left a lot of feedback on the PR: https://github.com/openwisp/netjsonconfig/pull/91#pullrequestreview-51475509
Federico On Fri, Jul 21, 2017 at 10:57 AM Edoardo Putti <[email protected]> wrote: > Hello everyone > > we finally have a PR waiting for the AirOS v8.3 backend [0] > > As you can see there are ~3k lines of code to review so this week has been > directed to fix the simple things, style, indentation, naming and such, > > As you can see there are still things to do [1] after much work so this > week looks like "death by a thousands cuts" > > On Thursday I found something interesting and posted this issue [2], it > seems that defining a custom schema can add definition and constraint but > it can't override the defaults. > > The schema is used in various places in the openwisp project > (netjsonconfig, netjson web editor) and this could be a problem only in one > implementation, I will investigate on this later. > > I know for sure that nemesis has begun testing my work on his hardware, we > talked about how to do some things (checking output, resetting antenna,...) > and I'm happy to have someone else to check and double check things. > > Today is dedicated to trying to keep test coverage high, my PR lower by > 3.2% this metric and it's blocking the merge. > > As always enjoy the weekend because we are coming with shiny new things > that will break your configuration! > > [0]: https://github.com/openwisp/netjsonconfig/pull/91 > [1]: > https://github.com/openwisp/netjsonconfig/pull/91/commits/107ff99f2ad397e38f0b515144c20461434f193e > [2]: https://github.com/openwisp/netjsonconfig/issues/93 > > -- > You received this message because you are subscribed to the Google Groups > "OpenWISP" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "OpenWISP" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
