One of the requirements in the project idea page is that users should be able to search for template by name, description and organization at the level of the library. My question is why should users be able to search for templates by organization when organizations' definitions (url, description, etc) can/will be different with different admins? my argument is this: let's assume two admins A and B, admin A creates a public template belonging to org1 and sends it to the template library. admin B comes to the library and because he has an organization on his local openwisp instance call org1, he searches for templates which belongs to org1 and gets what was created by admin A and then imports it. the org1 of admin A and admin B can/will have different definitions (url, description, etc) they might just be the same in the name field and different in other fields. will this not cause a problem when admin B will be using the template imported? Why not we send the templates to the library together with the organization and its definition. so that during template creation at the library, the organization is created first by the API and then used it in the template creation. and equally when the user imports the template from the library, he imports it together with the organization which was created by the template designer. thus in this way, we are sure the user using the imported template is using exactly what the designer had in terms of template definition and organization definition. With this, admins will be required to create and edit organizations at the template library, since they will created by the API and then when an admin updates an organization on his openwisp instance, the celery task synchronizes the contents of this organization at the library and its subscribers
On Fri, May 3, 2019 at 8:39 PM <[email protected]> wrote: > Hey Noumbissi, > > I did not understand your last email, could you expand your question so > it's clearer please? > > Federico > > > On Wednesday, May 1, 2019 at 3:17:56 AM UTC-4, Noumbissi Valere wrote: >> >> Hello Fed, >> Please i don't understand why we will be performing a search of templates >> for each organization in the template library. I don't know much about how >> the organizations are really used in a real OpenWisp server but i think >> different admins might have organizations with the same but different >> internal definitions like email, url and description, etc. so seeing a >> template in the library with name `org1` doesn't necessarily mean all it's >> definitions are same as the `org1` in my OpenWisp instance. >> Please can you explain why we need this? >> Thanks >> >> On Wed, Apr 17, 2019 at 2:08 AM Federico Capoano < >> [email protected]> wrote: >> >>> On Mon, Apr 15, 2019 at 2:34 PM Noumbissi Valere < >>> [email protected]> wrote: >>> >>>> 😁 Thanks Fed, >>>> So if say i have understood the problem, then we are saying, system >>>> should be able to find the variable in template.config and replace it's >>>> value with the default value supplied by the designer or the user of the >>>> import template. >>>> >>> >>> The user who imports the template will have to set the variables which >>> will likely change from network to network. >>> >>> >>>> say for example, one writes >>>> {"dns_servers": "4.4.4.4"} in the variable field, then the system >>>> should find *dns_servers* settings in template.config and replace it's >>>> value with "4.4.4.4" and this should be done at the level of the template >>>> and not device configuration. >>>> If am wrong, please correct me. >>>> >>> >>> Not only the system finds the variable, but it should be able to provide >>> a key/value widget (like the one we use for editing the configuration) that >>> allows users to change the values of the variable. >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "OpenWISP" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- > You received this message because you are subscribed to the Google Groups > "OpenWISP" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "OpenWISP" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
