Weekly update: This week, i pushed the following PRs: - Optimized template model <https://github.com/openwisp/django-netjsonconfig/pull/115/commits/7deea318cf4e898dcd9c7c1599d5a790317361cb> : performed changes on the template model. - JavaScript Validation <https://github.com/openwisp/django-netjsonconfig/issues/116> : Ensure variable-default_values JavaScript validation passes.(need review) -API for serialization <https://github.com/openwisp/openwisp-controller/pull/101> : Added the API which will be used for serialization of templates during imports (needs review). -API for search <https://github.com/openwisp/django-netjsonconfig/pull/115/commits/65c5d388e58049aaef0d8373f0504939b2d30072> : Added API to enable list of public templates and the search of public templates by name and description (needs review).
Am waiting for response to the last comment on Add logic for template import <https://github.com/openwisp/openwisp-controller/pull/102> . Going to work on: -Next week, i intend to work on the backend features to make importation possible. So admins and mentors can start importing and sharing templates while waiting for the front end. On Fri, Jun 7, 2019 at 2:43 PM Federico Capoano <[email protected]> wrote: > Hi Noumbissi, > > I guess all the fields except internal notes and organization, do you have > additional suggestions? > > Federico > > On Fri, Jun 7, 2019 at 4:32 AM Noumbissi Valere <[email protected]> > wrote: > >> Good day mentors, >> Please I wish to know the various template fields which should be >> serialized and exported during the importation of a an external template. >> >> On Tue, Jun 4, 2019 at 12:40 AM Federico Capoano < >> [email protected]> wrote: >> >>> Reviewed your PR in detail. >>> >>> The JS part needs some improvement on the UX side: I see the JS >>> validation fails when using variables (although it's still possible to save >>> the template) even though the result is valid. >>> >>> I left instrucstions and asked you to create 2 new issues which I want >>> us to work soon. >>> >>> Let me know if everything is clear. >>> >>> Federico >>> >>> On Fri, May 31, 2019 at 3:19 PM Noumbissi Valere < >>> [email protected]> wrote: >>> >>>> Weekly update, >>>> During the week, i was working on solving issue 93 >>>> <https://github.com/openwisp/django-netjsonconfig/issues/93> . >>>> >>>> Work done: >>>> with respect to the last commit on PR 115 >>>> <https://github.com/openwisp/django-netjsonconfig/pull/115/commits/9285773e9abd9f3e474e081989325c42747b630c> >>>> , >>>> It is now possible to declare variables in the web UI both at template and >>>> device creation. >>>> >>>> Currently working on. >>>> I am currently working on how to make variable declaration in the >>>> advance mode pass the Schema validation using JavaScript. >>>> >>>> >>>> On Sat, May 25, 2019 at 12:20 AM Federico Capoano < >>>> [email protected]> wrote: >>>> >>>>> PR reviewed, ping me when last changes are done. >>>>> >>>>> Next step: I want us to focus on this and the issues mentioned in >>>>> there: https://github.com/openwisp/django-netjsonconfig/issues/93 >>>>> Without solving those, we won't be able to make this feature work as >>>>> we want. >>>>> Keep in mind the validation can fail also in the javascript >>>>> validation, we'll have to look for a solution to that as well. >>>>> The strategy of filling the sample values may work as well in the >>>>> javascript validation. >>>>> >>>>> Federico >>>>> >>>>> On Fri, May 24, 2019 at 3:23 PM Noumbissi Valere < >>>>> [email protected]> wrote: >>>>> >>>>>> 5.19 - 5.24 >>>>>> I worked on the PR 115 >>>>>> <https://github.com/openwisp/django-netjsonconfig/pull/115> in which >>>>>> i modified the Template model to enable: >>>>>> -switching between the various types of templates (private, public, >>>>>> import and secret_key) >>>>>> - added additional fields which will be needed for this functionality >>>>>> - ensure variable validation with the backend >>>>>> >>>>>> Going to work on: >>>>>> - improve PR 115 >>>>>> <https://github.com/openwisp/django-netjsonconfig/pull/115> if >>>>>> mentors request for changes >>>>>> - implement the feature for template importing. this means i will >>>>>> need to work on issue 96 >>>>>> <https://github.com/openwisp/openwisp-controller/issues/96> and issue >>>>>> 95 <https://github.com/openwisp/openwisp-controller/issues/95> >>>>>> >>>>>> On Sun, May 19, 2019 at 7:16 PM Federico Capoano < >>>>>> [email protected]> wrote: >>>>>> >>>>>>> Update: I reviewed the current work Noumbissi has done, things are >>>>>>> going well. >>>>>>> >>>>>>> I talked with Noumbissi to define the current priority: make sure >>>>>>> the sharing and import of templates works, taking in consideration the >>>>>>> validation of the template contents and the interaction with variables, >>>>>>> which is the hardest part (to understand more this point read this >>>>>>> issue: >>>>>>> https://github.com/openwisp/django-netjsonconfig/issues/93) >>>>>>> >>>>>>> Federico >>>>>>> >>>>>>> >>>>>>> On Sunday, May 19, 2019 at 12:15:25 PM UTC-4, Noumbissi Valere wrote: >>>>>>>> >>>>>>>> 5.12 - 5.18 >>>>>>>> Sorry for sending for this late. i thought since i don't have any >>>>>>>> PR yet, a report won't be necessary. >>>>>>>> I created the issues for the different sections of the projects >>>>>>>> which will enable me and mentors track my progress. >>>>>>>> The issues are still to be reviewed and modifications made if >>>>>>>> needed. >>>>>>>> >>>>>>>> Currently: >>>>>>>> Federico demanded for a discussion on the project before i go into >>>>>>>> details. thus i am still waiting to have that discussion. >>>>>>>> While waiting for this discussion, i am working on issue #112 >>>>>>>> >>>>>>> -- >>>>>>> You received this message because you are subscribed to the Google >>>>>>> Groups "OpenWISP" group. >>>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>>> send an email to [email protected]. >>>>>>> To view this discussion on the web, visit >>>>>>> https://groups.google.com/d/msgid/openwisp/426fb520-3712-4db8-b1ae-d8e7e3a64fb5%40googlegroups.com >>>>>>> <https://groups.google.com/d/msgid/openwisp/426fb520-3712-4db8-b1ae-d8e7e3a64fb5%40googlegroups.com?utm_medium=email&utm_source=footer> >>>>>>> . >>>>>>> For more options, visit https://groups.google.com/d/optout. >>>>>>> >>>>>> -- >>>>>> You received this message because you are subscribed to the Google >>>>>> Groups "OpenWISP" group. >>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>> send an email to [email protected]. >>>>>> To view this discussion on the web, visit >>>>>> https://groups.google.com/d/msgid/openwisp/CAOwnGe4e51WUbXk4b1LeK9r4aBQ8iDg9hugDebu6f6pqj8ei8g%40mail.gmail.com >>>>>> <https://groups.google.com/d/msgid/openwisp/CAOwnGe4e51WUbXk4b1LeK9r4aBQ8iDg9hugDebu6f6pqj8ei8g%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>>> . >>>>>> For more options, visit https://groups.google.com/d/optout. >>>>>> >>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "OpenWISP" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to [email protected]. >>>>> To view this discussion on the web, visit >>>>> https://groups.google.com/d/msgid/openwisp/CAERYH6XCeN594yDGvWuneD1PUwTY1M%2BBJ0Fw4ZdJ0zyc%3Db%3DDbw%40mail.gmail.com >>>>> <https://groups.google.com/d/msgid/openwisp/CAERYH6XCeN594yDGvWuneD1PUwTY1M%2BBJ0Fw4ZdJ0zyc%3Db%3DDbw%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>> . >>>>> For more options, visit https://groups.google.com/d/optout. >>>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "OpenWISP" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> To view this discussion on the web, visit >>>> https://groups.google.com/d/msgid/openwisp/CAOwnGe65sFWAfa1znb0A9ajdJhOAMKco-oHUrnXZpK-4bawyNg%40mail.gmail.com >>>> <https://groups.google.com/d/msgid/openwisp/CAOwnGe65sFWAfa1znb0A9ajdJhOAMKco-oHUrnXZpK-4bawyNg%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>> . >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "OpenWISP" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web, visit >>> https://groups.google.com/d/msgid/openwisp/CAERYH6Whz1UkfeODV%2B_8hUhVRtNWCX82otpeC9G7TCuzo3NrZQ%40mail.gmail.com >>> <https://groups.google.com/d/msgid/openwisp/CAERYH6Whz1UkfeODV%2B_8hUhVRtNWCX82otpeC9G7TCuzo3NrZQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> For more options, visit https://groups.google.com/d/optout. >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "OpenWISP" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web, visit >> https://groups.google.com/d/msgid/openwisp/CAOwnGe4gHig-S6RwfeVGZ4mcYtb%2BvuY_BLaKmme1ao3Tgn3VuA%40mail.gmail.com >> <https://groups.google.com/d/msgid/openwisp/CAOwnGe4gHig-S6RwfeVGZ4mcYtb%2BvuY_BLaKmme1ao3Tgn3VuA%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> For more options, visit https://groups.google.com/d/optout. >> > -- > You received this message because you are subscribed to the Google Groups > "OpenWISP" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web, visit > https://groups.google.com/d/msgid/openwisp/CAERYH6XkFapd47T_Lrep5fs8XUySLjocFcjP%2B954YvXEmmCpsQ%40mail.gmail.com > <https://groups.google.com/d/msgid/openwisp/CAERYH6XkFapd47T_Lrep5fs8XUySLjocFcjP%2B954YvXEmmCpsQ%40mail.gmail.com?utm_medium=email&utm_source=footer> > . > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "OpenWISP" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web, visit https://groups.google.com/d/msgid/openwisp/CAOwnGe6r%2BQ5_1VbkpqEY8u2eNgAk5QAkZe6gQ11aErsx7u8AWQ%40mail.gmail.com. For more options, visit https://groups.google.com/d/optout.
