Hey Federico, The README files have been fixed and updated https://github.com/openwisp/openwisp-template-library-frontend/pull/5 https://github.com/openwisp/openwisp-template-library-backend/pull/11
On Wed, Aug 21, 2019 at 1:57 AM Noumbissi Valere <[email protected]> wrote: > Hi Federico, > Ok. I will do that. > In the meantime am readily available to perform corrections on the repos > if errors were found during testing. > > On Wed, Aug 21, 2019, 1:53 AM Federico Capoano <[email protected]> > wrote: > >> Hey Noumbissi, can you make sure those instructions are in the README of >> the frontend please? >> >> Also add a link to those instructions to the backend README. >> >> F. >> >> On Tue, Aug 20, 2019 at 8:15 PM Noumbissi Valere < >> [email protected]> wrote: >> >>> Good day mentors >>> >>> I prepared the instructions which could be followed to get the work up >>> and running on a machine. >>> after this PR >>> <https://github.com/openwisp/openwisp-template-library-backend/pull/10> is >>> merged to the backend, these instructions can be followed. >>> >>> >>> On Mon, Aug 19, 2019 at 2:39 AM Federico Capoano < >>> [email protected]> wrote: >>> >>>> Reviewed and merged, think about a way (eg: prepare some instructions >>>> or deploy an instance somewhere online) or to help us testing your work >>>> please. >>>> >>>> Federico >>>> >>>> On Fri, Aug 16, 2019 at 10:04 AM Noumbissi Valere < >>>> [email protected]> wrote: >>>> >>>>> Good day mentors. >>>>> >>>>> *weekly report* >>>>> This week i worked on >>>>> Frontend library >>>>> <https://github.com/openwisp/openwisp-template-library-frontend/pull/5> . >>>>> I created the structure, wrote the code for the final logics which were >>>>> discussed, added the tests for the various components implemented and add >>>>> some notes to the README. >>>>> Backend Library >>>>> <https://github.com/openwisp/openwisp-template-library-backend/pull/8>. >>>>> I added some notes in the readme file of this library >>>>> >>>>> Openwisp-controller >>>>> <https://github.com/openwisp/openwisp-controller/pull/115>. Increase >>>>> coverage tests and updated the readme file. Concerning the last comment on >>>>> this PR, I need to pass the Vpn to the Asbtract Template class. this is >>>>> used to create Vpn during imports. If i move the Vpn class back down, i >>>>> will get the error *which says am using Vpn before defining it.* I have >>>>> search on a way round it but found none. I love to correct this too but >>>>> don't know what else to do because that Vpn needs to down to the abstract >>>>> class. Please can you help me on a way round this? thanks. >>>>> >>>>> django_netjsonconfig >>>>> <https://github.com/openwisp/django-netjsonconfig/pull/124>. Increase >>>>> coverage test and updated the README file. >>>>> >>>>> *To do next:* >>>>> Work hand in gloves with mentors to test this work to make all the >>>>> necessary and cited features were implemented and equally perform changes >>>>> if any is requested. >>>>> >>>>> >>>>> On Thu, Aug 15, 2019 at 8:17 PM Federico Capoano < >>>>> [email protected]> wrote: >>>>> >>>>>> I'm reviewing the PRs now, I should have replied to your question via >>>>>> IM. >>>>>> >>>>>> Fed >>>>>> >>>>>> On Fri, Aug 9, 2019 at 10:00 AM Noumbissi Valere < >>>>>> [email protected]> wrote: >>>>>> >>>>>>> Good day mentors. >>>>>>> >>>>>>> Weekly report >>>>>>> This week, i worked the following PRs: >>>>>>> https://github.com/openwisp/openwisp-template-library-backend/pull/8 >>>>>>> https://github.com/openwisp/openwisp-controller/pull/115 >>>>>>> >>>>>>> And the frontend library. Its PR is not yet ready but as of now, it >>>>>>> is possible to list templates found on the backend server, search for >>>>>>> templates by name, organization and description, view template detail >>>>>>> and >>>>>>> view organization details of the template. >>>>>>> >>>>>>> Currently working on: >>>>>>> I am currently working on social login and password management. >>>>>>> >>>>>>> to do next: >>>>>>> -add view feature to create templates on the frontend >>>>>>> -write tests >>>>>>> -Send this PR >>>>>>> -Perform changes if need be >>>>>>> -Document all my work for the repos i have worked on for the work >>>>>>> done. >>>>>>> >>>>>>> Question: >>>>>>> One of the features on the project idea page is to enable admins to >>>>>>> add, update and delete organizations on the frontend. My question is why >>>>>>> are we doing this, each openwisp instance have this functionality >>>>>>> already. >>>>>>> I am proposing that we let admins handle organizations for the >>>>>>> templates as >>>>>>> they have been doing and then on the library they create just >>>>>>> templates. on >>>>>>> the library, the organization of the template can be gotten from the >>>>>>> templates during its creation since each template is serialized with its >>>>>>> organization field. updates will equally be done when celery launch the >>>>>>> synchronization task. >>>>>>> >>>>>>> On Fri, Aug 2, 2019 at 10:45 PM Noumbissi Valere < >>>>>>> [email protected]> wrote: >>>>>>> >>>>>>>> Good day mentors: >>>>>>>> >>>>>>>> I ended with my Exams today. I know I am way behind schedule and >>>>>>>> have limited time. >>>>>>>> Will used the remaining week to progress and hopefully finish up. >>>>>>>> This week I worked on >>>>>>>> https://github.com/openwisp/django-netjsonconfig/pull/124 >>>>>>>> <https://github.com/openwisp/django-netjsonconfig/pull/124#discussion-diff-305152592R173> >>>>>>>> >>>>>>>> Next Week. >>>>>>>> I Intend to work on the Frontend library next week >>>>>>>> >>>>>>>> >>>>>>>> On Sat, Jul 27, 2019 at 7:38 PM Noumbissi Valere < >>>>>>>> [email protected]> wrote: >>>>>>>> >>>>>>>>> Good day mentors. >>>>>>>>> >>>>>>>>> Sorry for the late reply, >>>>>>>>> I am currently writing my final year exams so i don't code as much >>>>>>>>> as before reason why I am slow. I will be finishing with the exams on >>>>>>>>> the >>>>>>>>> 2nd of August. >>>>>>>>> But I am currently working on addressing the issues which were >>>>>>>>> raised during the last review of my work when i have the chance to >>>>>>>>> work. I >>>>>>>>> will be sending a PR for this work soon. >>>>>>>>> >>>>>>>>> On Fri, Jul 19, 2019 at 11:20 PM Noumbissi Valere < >>>>>>>>> [email protected]> wrote: >>>>>>>>> >>>>>>>>>> Good day mentors. >>>>>>>>>> >>>>>>>>>> *Weekly report.* >>>>>>>>>> -I focused on performing changes requested by mentors for >>>>>>>>>> existing PRs. in the course of this, some PRs were merged and others >>>>>>>>>> required further changes which am currently working on. This was to >>>>>>>>>> ensure >>>>>>>>>> that all the work i have done so far are approved and merged. >>>>>>>>>> >>>>>>>>>> *permission:* >>>>>>>>>> The time table for my final year examination is out and I am >>>>>>>>>> suppose to begin writing next week 24th July till the 2nd of August. >>>>>>>>>> I wish to take some days off in order to focus on this >>>>>>>>>> examination and will be back from the 2nd of August. >>>>>>>>>> During my days off, i will not be able to writes codes as before >>>>>>>>>> but will do my best to write some code and push when i have the time. >>>>>>>>>> >>>>>>>>>> On Sat, Jul 13, 2019 at 12:22 AM Federico Capoano < >>>>>>>>>> [email protected]> wrote: >>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> On Fri, Jul 12, 2019 at 4:51 PM Noumbissi Valere < >>>>>>>>>>> [email protected]> wrote: >>>>>>>>>>> >>>>>>>>>>>> Good day mentors. >>>>>>>>>>>> >>>>>>>>>>>> *Weekly Report* >>>>>>>>>>>> >>>>>>>>>>>> I worked on the following PRs. >>>>>>>>>>>> >>>>>>>>>>>> PR 8 backend >>>>>>>>>>>> <https://github.com/openwisp/openwisp-template-library-backend/pull/8>. >>>>>>>>>>>> in which i created the directory structure of library backend, >>>>>>>>>>>> implemented >>>>>>>>>>>> socail and local login and enable APIs for CRUD of organizations >>>>>>>>>>>> from >>>>>>>>>>>> openwisp_users, external_template creation, get detail template and >>>>>>>>>>>> functionality to list and search for templates from >>>>>>>>>>>> openwisp_controller. >>>>>>>>>>>> With these, I think i have exhausted the objectives of this >>>>>>>>>>>> backend as per >>>>>>>>>>>> the the project idea page. (waiting for review). >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> I've added some comments. >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>>> PR 81 CRUD org >>>>>>>>>>>> <https://github.com/openwisp/openwisp-users/pull/81>. >>>>>>>>>>>> Implemented API to list, create, update, delete and get details >>>>>>>>>>>> for a >>>>>>>>>>>> particular organization. (waiting for review) >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Did we say we would do this in openwisp-users? I think you can >>>>>>>>>>> do that in the template library backend for the moment. >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>>> PR 115 create template >>>>>>>>>>>> <https://github.com/openwisp/openwisp-controller/pull/115>. >>>>>>>>>>>> Moved API to create external templates from django_netjsonconfig to >>>>>>>>>>>> openwisp_controller. (waiting for review) >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> I've added some comments and requested changes. >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>>> *Next work.* >>>>>>>>>>>> Next week, i intend to >>>>>>>>>>>> >>>>>>>>>>>> - perform changes requested by mentors if any >>>>>>>>>>>> - begin with the creation of the library frontend >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> Great. >>>>>>>>>>> >>>>>>>>>>> Thanks >>>>>>>>>>> Federico >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> You received this message because you are subscribed to the >>>>>>>>>>> Google Groups "OpenWISP" group. >>>>>>>>>>> To unsubscribe from this group and stop receiving emails from >>>>>>>>>>> it, send an email to [email protected]. >>>>>>>>>>> To view this discussion on the web, visit >>>>>>>>>>> https://groups.google.com/d/msgid/openwisp/CAERYH6U8qSKxryB3wCuMW0ra_Yghhz%3DDddShba0XRj876vS32g%40mail.gmail.com >>>>>>>>>>> <https://groups.google.com/d/msgid/openwisp/CAERYH6U8qSKxryB3wCuMW0ra_Yghhz%3DDddShba0XRj876vS32g%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>>>>>>>> . >>>>>>>>>>> For more options, visit https://groups.google.com/d/optout. >>>>>>>>>>> >>>>>>>>>> -- >>>>>>> You received this message because you are subscribed to the Google >>>>>>> Groups "OpenWISP" group. >>>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>>> send an email to [email protected]. >>>>>>> To view this discussion on the web, visit >>>>>>> https://groups.google.com/d/msgid/openwisp/CAOwnGe4_FAs0AnffiEJYvk0VfZLzYxrA5VHmjXqBn1n61hNX%3DQ%40mail.gmail.com >>>>>>> <https://groups.google.com/d/msgid/openwisp/CAOwnGe4_FAs0AnffiEJYvk0VfZLzYxrA5VHmjXqBn1n61hNX%3DQ%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>>>> . >>>>>>> >>>>>> -- >>>>>> You received this message because you are subscribed to the Google >>>>>> Groups "OpenWISP" group. >>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>> send an email to [email protected]. >>>>>> To view this discussion on the web, visit >>>>>> https://groups.google.com/d/msgid/openwisp/CAERYH6WrdwAKpNa7hEi2owSpqsVg8SLNO1GxZjv%2Bk5OPndvfXw%40mail.gmail.com >>>>>> <https://groups.google.com/d/msgid/openwisp/CAERYH6WrdwAKpNa7hEi2owSpqsVg8SLNO1GxZjv%2Bk5OPndvfXw%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>>> . >>>>>> >>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "OpenWISP" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to [email protected]. >>>>> To view this discussion on the web, visit >>>>> https://groups.google.com/d/msgid/openwisp/CAOwnGe6dEr4-wUPUK8hPhbFA7d%3D_qeXvLqGQSrwoW3FEGtRmKA%40mail.gmail.com >>>>> <https://groups.google.com/d/msgid/openwisp/CAOwnGe6dEr4-wUPUK8hPhbFA7d%3D_qeXvLqGQSrwoW3FEGtRmKA%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>>> . >>>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "OpenWISP" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> To view this discussion on the web, visit >>>> https://groups.google.com/d/msgid/openwisp/CAERYH6WwqL65J-0js1z3n97eMGo4cXG2LUpRW7MCj5HE_kmaPA%40mail.gmail.com >>>> <https://groups.google.com/d/msgid/openwisp/CAERYH6WwqL65J-0js1z3n97eMGo4cXG2LUpRW7MCj5HE_kmaPA%40mail.gmail.com?utm_medium=email&utm_source=footer> >>>> . >>>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "OpenWISP" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web, visit >>> https://groups.google.com/d/msgid/openwisp/CAOwnGe6%3DQvWqbuAu0xFq0d5J%3DyN%3DRjLQg8Wk1P43NAGFPgu_sw%40mail.gmail.com >>> <https://groups.google.com/d/msgid/openwisp/CAOwnGe6%3DQvWqbuAu0xFq0d5J%3DyN%3DRjLQg8Wk1P43NAGFPgu_sw%40mail.gmail.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "OpenWISP" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web, visit >> https://groups.google.com/d/msgid/openwisp/CAERYH6UcnVABeCb2FetXjfsEZ7-iLz7kNCdTpRv56Dd2MOyx7A%40mail.gmail.com >> <https://groups.google.com/d/msgid/openwisp/CAERYH6UcnVABeCb2FetXjfsEZ7-iLz7kNCdTpRv56Dd2MOyx7A%40mail.gmail.com?utm_medium=email&utm_source=footer> >> . >> > -- You received this message because you are subscribed to the Google Groups "OpenWISP" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web, visit https://groups.google.com/d/msgid/openwisp/CAOwnGe4AEu66tCJx8UeBjLMx%3Dph4ZkFw0xZwM%2Bm7BZJya-yU4A%40mail.gmail.com.
