Author: jow Date: 2014-10-27 12:07:38 +0100 (Mon, 27 Oct 2014) New Revision: 43080
Modified: trunk/package/utils/px5g-standalone/Makefile trunk/package/utils/px5g-standalone/src/library/x509write.c Log: px5g-standalone: use /dev/urandom to initialize serial (#18232) Signed-off-by: Jo-Philipp Wich <[email protected]> Modified: trunk/package/utils/px5g-standalone/Makefile =================================================================== --- trunk/package/utils/px5g-standalone/Makefile 2014-10-27 11:02:23 UTC (rev 43079) +++ trunk/package/utils/px5g-standalone/Makefile 2014-10-27 11:07:38 UTC (rev 43080) @@ -1,5 +1,5 @@ # -# Copyright (C) 2010 Jo-Philipp Wich <[email protected]> +# Copyright (C) 2010-2014 Jo-Philipp Wich <[email protected]> # # This is free software, licensed under the GNU General Public License v2. # See /LICENSE for more information. @@ -8,7 +8,7 @@ include $(TOPDIR)/rules.mk PKG_NAME:=px5g -PKG_RELEASE:=1 +PKG_RELEASE:=2 PKG_BUILD_DIR := $(BUILD_DIR)/$(PKG_NAME) PKG_CHECK_FORMAT_SECURITY:=0 Modified: trunk/package/utils/px5g-standalone/src/library/x509write.c =================================================================== --- trunk/package/utils/px5g-standalone/src/library/x509write.c 2014-10-27 11:02:23 UTC (rev 43079) +++ trunk/package/utils/px5g-standalone/src/library/x509write.c 2014-10-27 11:07:38 UTC (rev 43080) @@ -1000,6 +1000,26 @@ } /* + * Create a random serial + */ +static int get_random_serial(void) +{ + int random = 0; + FILE *fd; + + fd = fopen("/dev/urandom", "r"); + + if (fd) { + if (fread(&random, 1, sizeof(random), fd) != sizeof(random)) + random = 0; + + fclose(fd); + } + + return random; +} + +/* * Create a self signed certificate */ int x509write_create_sign(x509_raw *chain, rsa_context *privkey) @@ -1020,8 +1040,11 @@ /* * CertificateSerialNumber ::= INTEGER */ - srand((unsigned int) time(NULL)); - serial = rand(); + serial = get_random_serial(); + + if (serial == 0) + return 1; + if ((ret = asn1_add_int(serial, &chain->serial)) != 0) return ret; _______________________________________________ openwrt-commits mailing list [email protected] https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-commits
