Author: blogic Date: 2014-12-01 17:15:08 +0100 (Mon, 01 Dec 2014) New Revision: 43471
Modified: trunk/target/linux/generic/files/drivers/net/phy/ar8216.c trunk/target/linux/generic/files/drivers/net/phy/ar8216.h Log: ar8216: factor out reg_port_stats_base parameters to ar8xxx_chip Factor out reg_port_stats_base parameters to ar8xxx_chip. Remove related chip_is_... checks. Signed-off-by: Heiner Kallweit <[email protected]> Modified: trunk/target/linux/generic/files/drivers/net/phy/ar8216.c =================================================================== --- trunk/target/linux/generic/files/drivers/net/phy/ar8216.c 2014-12-01 16:15:02 UTC (rev 43470) +++ trunk/target/linux/generic/files/drivers/net/phy/ar8216.c 2014-12-01 16:15:08 UTC (rev 43471) @@ -76,6 +76,10 @@ bool config_at_probe; bool mii_lo_first; + /* parameters to calculate REG_PORT_STATS_BASE */ + unsigned reg_port_stats_start; + unsigned reg_port_stats_length; + int (*hw_init)(struct ar8xxx_priv *priv); void (*cleanup)(struct ar8xxx_priv *priv); @@ -577,13 +581,8 @@ lockdep_assert_held(&priv->mib_lock); - if (chip_is_ar8327(priv) || chip_is_ar8337(priv)) - base = AR8327_REG_PORT_STATS_BASE(port); - else if (chip_is_ar8236(priv) || - chip_is_ar8316(priv)) - base = AR8236_REG_PORT_STATS_BASE(port); - else - base = AR8216_REG_PORT_STATS_BASE(port); + base = priv->chip->reg_port_stats_start + + priv->chip->reg_port_stats_length * port; mib_stats = &priv->mib_stats[port * priv->chip->num_mibs]; for (i = 0; i < priv->chip->num_mibs; i++) { @@ -885,6 +884,9 @@ static const struct ar8xxx_chip ar8216_chip = { .caps = AR8XXX_CAP_MIB_COUNTERS, + .reg_port_stats_start = 0x19000, + .reg_port_stats_length = 0xa0, + .hw_init = ar8216_hw_init, .init_globals = ar8216_init_globals, .init_port = ar8216_init_port, @@ -953,6 +955,10 @@ static const struct ar8xxx_chip ar8236_chip = { .caps = AR8XXX_CAP_MIB_COUNTERS, + + .reg_port_stats_start = 0x20000, + .reg_port_stats_length = 0x100, + .hw_init = ar8216_hw_init, .init_globals = ar8236_init_globals, .init_port = ar8216_init_port, @@ -1038,6 +1044,10 @@ static const struct ar8xxx_chip ar8316_chip = { .caps = AR8XXX_CAP_GIGE | AR8XXX_CAP_MIB_COUNTERS, + + .reg_port_stats_start = 0x20000, + .reg_port_stats_length = 0x100, + .hw_init = ar8316_hw_init, .init_globals = ar8316_init_globals, .init_port = ar8216_init_port, @@ -1831,6 +1841,9 @@ .config_at_probe = true, .mii_lo_first = true, + .reg_port_stats_start = 0x1000, + .reg_port_stats_length = 0x100, + .hw_init = ar8327_hw_init, .cleanup = ar8327_cleanup, .init_globals = ar8327_init_globals, Modified: trunk/target/linux/generic/files/drivers/net/phy/ar8216.h =================================================================== --- trunk/target/linux/generic/files/drivers/net/phy/ar8216.h 2014-12-01 16:15:02 UTC (rev 43470) +++ trunk/target/linux/generic/files/drivers/net/phy/ar8216.h 2014-12-01 16:15:08 UTC (rev 43471) @@ -164,8 +164,6 @@ #define AR8216_REG_PORT_RATE(_i) (AR8216_PORT_OFFSET(_i) + 0x000c) #define AR8216_REG_PORT_PRIO(_i) (AR8216_PORT_OFFSET(_i) + 0x0010) -#define AR8216_REG_PORT_STATS_BASE(_i) (0x19000 + (_i) * 0xa0) - #define AR8216_STATS_RXBROAD 0x00 #define AR8216_STATS_RXPAUSE 0x04 #define AR8216_STATS_RXMULTI 0x08 @@ -217,8 +215,6 @@ #define AR8236_PORT_VLAN2_VLAN_MODE BITS(30, 2) #define AR8236_PORT_VLAN2_VLAN_MODE_S 30 -#define AR8236_REG_PORT_STATS_BASE(_i) (0x20000 + (_i) * 0x100) - #define AR8236_STATS_RXBROAD 0x00 #define AR8236_STATS_RXPAUSE 0x04 #define AR8236_STATS_RXMULTI 0x08 @@ -455,8 +451,6 @@ #define AR8327_REG_PORT_HOL_CTRL1(_i) (0x974 + (_i) * 0x8) #define AR8327_PORT_HOL_CTRL1_EG_MIRROR_EN BIT(16) -#define AR8327_REG_PORT_STATS_BASE(_i) (0x1000 + (_i) * 0x100) - #define AR8337_PAD_MAC06_EXCHANGE_EN BIT(31) /* port speed */ _______________________________________________ openwrt-commits mailing list [email protected] https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-commits
