Author: nbd
Date: 2015-04-16 22:09:30 +0200 (Thu, 16 Apr 2015)
New Revision: 45463

Modified:
   trunk/package/base-files/files/etc/init.d/led
Log:
base-files: reorder led trigger/brightness writes

Depending on configuration, disable the LED before writing the trigger
and enable it after writing it. Fixes LEDs where the value defaults to 1

Signed-off-by: Felix Fietkau <[email protected]>

Modified: trunk/package/base-files/files/etc/init.d/led
===================================================================
--- trunk/package/base-files/files/etc/init.d/led       2015-04-16 20:09:21 UTC 
(rev 45462)
+++ trunk/package/base-files/files/etc/init.d/led       2015-04-16 20:09:30 UTC 
(rev 45463)
@@ -34,14 +34,17 @@
 
        [ -e /sys/class/leds/${sysfs}/brightness ] && {
                echo "setting up led ${name}"
-               [ "$default" != nil ] && {
-                       [ $default -eq 1 ] &&
-                               echo 1 >/sys/class/leds/${sysfs}/brightness
-                       [ $default -eq 1 ] ||
-                               echo 0 >/sys/class/leds/${sysfs}/brightness
-               }
+
+               [ "$default" = 0 ] ||
+                       echo 0 >/sys/class/leds/${sysfs}/brightness
+
                echo $trigger > /sys/class/leds/${sysfs}/trigger 2> /dev/null
-               [ $? = 0 ] || {
+               ret="$?"
+
+               [ $default = 1 ] &&
+                       echo 1 >/sys/class/leds/${sysfs}/brightness
+
+               [ $ret = 0 ] || {
                        echo >&2 "Skipping trigger '$trigger' for led '$name' 
due to missing kernel module"
                        return 1
                }
_______________________________________________
openwrt-commits mailing list
[email protected]
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-commits

Reply via email to