Author: blogic
Date: 2016-02-12 09:29:11 +0100 (Fri, 12 Feb 2016)
New Revision: 48696

Modified:
   trunk/package/kernel/gpio-button-hotplug/src/gpio-button-hotplug.c
Log:
kernel: gpio-button-hotplug: update to use threaded irq's

Many gpio controllers 'cansleep' due to the fact that they are behind busses
e.g. i2c etc.

Using threaded irq's allows for 'sleep-able' gpio's to be used.

Signed-off-by: Pushpal Sidhu <[email protected]>
Signed-off-by: Tim Harvey <[email protected]>

Modified: trunk/package/kernel/gpio-button-hotplug/src/gpio-button-hotplug.c
===================================================================
--- trunk/package/kernel/gpio-button-hotplug/src/gpio-button-hotplug.c  
2016-02-11 22:48:36 UTC (rev 48695)
+++ trunk/package/kernel/gpio-button-hotplug/src/gpio-button-hotplug.c  
2016-02-12 08:29:11 UTC (rev 48696)
@@ -555,20 +555,17 @@
                struct gpio_keys_button *button = &pdata->buttons[i];
                struct gpio_keys_button_data *bdata = &bdev->data[i];
 
-               if (bdata->can_sleep) {
-                       dev_err(&pdev->dev, "skipping gpio:%d, it can sleep\n", 
button->gpio);
-                       continue;
-               }
                if (!button->irq)
                        button->irq = gpio_to_irq(button->gpio);
                if (button->irq < 0) {
                        dev_err(&pdev->dev, "failed to get irq for gpio:%d\n", 
button->gpio);
                        continue;
                }
-               ret = devm_request_irq(&pdev->dev, button->irq, 
button_handle_irq,
-                                       IRQF_TRIGGER_RISING | 
IRQF_TRIGGER_FALLING,
-                                       dev_name(&pdev->dev), bdata);
-               if (ret)
+
+               ret = devm_request_threaded_irq(&pdev->dev, button->irq, NULL, 
button_handle_irq,
+                                               IRQF_TRIGGER_RISING | 
IRQF_TRIGGER_FALLING,
+                                               dev_name(&pdev->dev), bdata);
+               if (ret < 0)
                        dev_err(&pdev->dev, "failed to request irq:%d for 
gpio:%d\n", button->irq, button->gpio);
                else
                        dev_dbg(&pdev->dev, "gpio:%d has irq:%d\n", 
button->gpio, button->irq);
_______________________________________________
openwrt-commits mailing list
[email protected]
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-commits

Reply via email to