Harald Schiöberg wrote:
>> thats why I added the set_mac_address function and i'm calling it in the
>> initialization. you should get something stange now from
>> if ( (netdev = dev_get_by_name("eth0")) )
>> netdev->set_mac_address(netdev, &address);
>>
>> I'll check that.
>> Harald
>
> This patch seems to work. I stripped all the 'real' stuff from
> set_mac_address and let the very same code in eth_open care for it.
> This doesn't matter as eth_open is called anyway as soon as
> the device is brought up.
Um, should we really be modifying code in ixp4xx_eth, which is common
code destined for upstream?
Shouldn't we instead be raising this issue with the author of that code
(Krzysztof Halasa, [EMAIL PROTECTED]) to work out how it should be done
properly?
I would strongly object to this change unless it had the blessing of the
upstream author.
-- Rod
_______________________________________________
openwrt-devel mailing list
[email protected]
http://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
