Hi Christoph, Your patch looks good to me, comments below :
Le lundi 21 janvier 2008, Christoph Muellner a écrit :
> +
> + /* Western Digital */
> + WDNetCenter,
> };
Please use upper case for the device enumeration.
>
> static void __init bcm4780_init(void) {
> @@ -134,6 +137,21 @@
> schedule_timeout(HZ * 5);
> }
>
> +static void __init NetCenter_init(void) {
Please name your function using lower case letters.
> + .leds = {
> + /* register_led changes values, so that we must
> exclude
> + * here to make NetCenter_init work */
> + //{ .name = "LED1", .gpio = 1 << 1},
> + //{ .name = "+5V", .gpio = 1 << 3},
> + //{ .name = "LED4", .gpio = 1 << 4},
> + //{ .name = "+12V", .gpio = 1 << 6},
Cannot the LEDs work after NetCenter_init was called ?
Thank you very much.
--
Best regards, Florian Fainelli
Email : [EMAIL PROTECTED]
http://openwrt.org
-------------------------------
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org http://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel
