On 09/07/2009 08:31 AM, Michael Buesch wrote:
On Monday 07 September 2009 15:23:59 Steve Brown wrote:
Michael Buesch wrote:
On Sunday 16 August 2009 17:23:40 Steve Brown wrote:
Found in the Asus GPL sources.
This is very noticable with a Seagate FreeAgent drive. Without the patch,
long writes give a "reset high speed usb" error and hang until
the drive is disconnnected. The patch solves that problem.
Steve
I applied this patch. Thanks a lot.
But I don't understand the second "allow building ohci driver without also building
ehci"
patch. Doesn't that trade one failure for another? If CONFIG_USB_EHCI_HCD_SSB,
the functions
won't be available. And as far as I can see CONFIG_USB_EHCI_HCD does not imply
CONFIG_USB_EHCI_HCD_SSB.
You are correct. The patch is incomplete. It needs to depend on both
CONFIG_USB_EHCI_HCD and CONFIG_USB_EHCI_HCD_SSB. I'll fix it and resubmit.
I found this while looking at a problem w/ the ohci driver and a
prolific rs232 dongle. I tried to build only the ohci driver and it
failed. The problem is that CONFIG_USB_EHCI_HCD_SSB is set by default in
brcm47xx's config-2.6.xx. So, even if you build without the ehci driver,
the calls to the ehci driver in the ohci driver are still compiled in
and the ohci driver fails to load.
Can you check if this is still true after my commit #17536?
Your commit fixed the problem.
Steve
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
