hi Malte,

I forgot to say that, this is for ubicom32 cpu that has no mmu, and other 
no-mmu cpu's,
there is no memory concern. 

this will not be the end of hush scripts changes, others are on the way.

"eval" may be fishy for ash, i don't know. May be making a global "switch" 
mechanism between ash/hush
is the solution to "isolate" different behaviour of shells.

regards
ugur

-----Original Message-----
From: openwrt-devel-boun...@lists.openwrt.org on behalf of Malte S. Stretz
Sent: Tue 20.10.2009 16:51
To: OpenWrt Development List
Subject: Re: [OpenWrt-Devel] [PATCH] firewall/iptables
 
On Tuesday 20 October 2009 14:58:49 Ugur DOGRU wrote:
> This patch is for firewall/iptables. Most of it is to fix some hush
> script problems.
>[...]

As most other init/hotplug scripts don't work with hush as well, I wonder why 
you went for the firewall only :)

What you "fixed" are actually not problems in the scripts, but workarounds for 
hush-limitations and un-localizing variables is prone to breaking some stuff 
(I fixed one such issue earlier this year).  The eval-code you used for 
assigning variables looks fishy as well but I never worked with hush so maybe 
PITAresque stuff like this is needed. Maybe you should just add the 50k and 
use ash instead?

Cheers,
Malte

-- 
   
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to