More stuff to follow later.
Signed-off-by: Andreas Mohr <[email protected]>
--- /dev/null 2009-05-14 19:20:59.000000000 +0200
+++
target/linux/generic-2.6/patches-2.6.30/696-b44_fix-wedge-when-using-netconsole.patch
2009-11-30 20:12:53.000000000 +0100
@@ -0,0 +1,58 @@
+From patchwork Mon Nov 30 08:15:41 2009
+Content-Type: text/plain; charset="utf-8"
+MIME-Version: 1.0
+Content-Transfer-Encoding: 7bit
+Subject: b44.c box lockup fix (netconsole): ratelimit NAPI poll error message
+Date: Mon, 30 Nov 2009 08:15:41 -0000
+From: David Miller <[email protected]>
+X-Patchwork-Id: 63627
+
+From: Andreas Mohr <[email protected]>
+Date: Wed, 25 Nov 2009 22:35:46 +0100
+
+> See
+> http://bugzilla.kernel.org/show_bug.cgi?id=14691
+> for background information.
+
+The patch below is what I'll check in to fix this, thanks.
+
+As for the r8169 side, that case is much more complicated
+to fix. That driver messes with the interrupt masking
+before the NAPI schedule check, instead of after it's
+sure that NAPI isn't already scheduled like b44 does.
+
+Therefore we might need to undo that programming or move
+it into the code block where __napi_schedule() is actually
+invoked.
+
+I'll queue this b44 patch up for -stable too.
+
+b44: Fix wedge when using netconsole.
+
+Fixes kernel bugzilla #14691
+
+Due to the way netpoll works, it is perfectly legal to see
+NAPI already scheduled when new device events are pending
+in b44_interrupt().
+
+So logging a message about it is wrong and in fact harmful.
+
+Based upon a patch by Andreas Mohr.
+
+Signed-off-by: David S. Miller <[email protected]>
+
+---
+drivers/net/b44.c | 3 ---
+ 1 files changed, 0 insertions(+), 3 deletions(-)
+--- a/drivers/net/b44.c
++++ b/drivers/net/b44.c
+@@ -912,9 +912,6 @@
+ bp->istat = istat;
+ __b44_disable_ints(bp);
+ __napi_schedule(&bp->napi);
+- } else {
+- printk(KERN_ERR PFX "%s: Error, poll already
scheduled\n",
+- dev->name);
+ }
+
+ irq_ack:
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
