On 2009-11-18 9:36 PM, Aleksandar Radovanovic wrote: > Fix a memory leak in hotplug2 environment handling. > Bump hotplug2 to the latest svn revision, remove obsolete patches. > > Memory leak is caused by the way hotplug2 handles environment variables, > using setenv() and unsetenv(). setenv() creates copies of the supplied > strings, but, due to a POSIX blunder, these copies are never destroyed > by unsetenv(), neither in glibc nor uclibc - not until the program > terminates. > > Since some events are handled directly in the main process, even when > configured with the "fork" worker, hotplug2 memory usage will keep > growing over time. This can be observed by running "udevtrigger" and > noting the increase in hotplug2 VmRSS after each run. > > This patch uses putenv() instead, which leaves storage management to > the caller, so that we can explicitly delete stuff when it's no longer > needed. > > Signed-off-by: Aleksandar Radovanovic <[email protected]> Applied in r18725, thanks.
- Felix _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
