Michael Buesch wrote:
> On Saturday 26 December 2009 02:06:36 [email protected] wrote:
>> Author: hauke
>> Date: 2009-12-26 02:06:36 +0100 (Sat, 26 Dec 2009)
>> New Revision: 18935
>>
>> Modified:
>>    trunk/package/mac80211/Config.in.b43
>>    trunk/package/mac80211/files/host_bin/b43-fwsquash.py
>> Log:
>> [mac80211] b43: Add L-PHY firemware files to squash script
>>
>> Use firmware 4.178.10.4 as default on.
>> Select firmware for all supported phy types and version as default.
>>
>> Close ticket #5978
> 
> 
>> @@ -65,7 +66,7 @@
>>  config B43_FW_SQUASH_PHYTYPES
>>      string "PHY types to include"
>>      depends on PACKAGE_kmod-b43 && B43_FW_SQUASH
>> -    default "G,LP,N"
>> +    default "A,AG,G,LP"
> 
> Well, why remove N and add A? They are both unsupported. :)
I have not read so clearly through the driver source. If A and AG are
not supported they should not be in the default list.

>> Modified: trunk/package/mac80211/files/host_bin/b43-fwsquash.py
>> ===================================================================
>> --- trunk/package/mac80211/files/host_bin/b43-fwsquash.py    2009-12-26 
>> 00:23:35 UTC (rev 18934)
>> +++ trunk/package/mac80211/files/host_bin/b43-fwsquash.py    2009-12-26 
>> 01:06:36 UTC (rev 18935)
>> @@ -65,7 +65,8 @@
>>      "ucode5.fw"             : (5,6,7,8,9,10,),
>>      "ucode11.fw"            : (11,12,),
>>      "ucode13.fw"            : (13,),
>> -    "pcm4.fw"               : (1,2,3,4,),
>> +    "ucode14.fw"            : (14,),
>> +    "ucode15.fw"            : (15,),
>>      "pcm5.fw"               : (5,6,7,8,9,10,),
>>  }
> 
> Why do we remove pcm4?
pcm4.fw is never loaded by the b43 driver. There is no reverence to this
file in the driver source and the new fwcutter version does not extract
it any more out of the firmware for b43 driver. Why should it still be
in this list, if there is no way to load it? It makes only sense when
using the b43-fwsquash.py script also for b43legacy.

Hauke

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to