I'd rather keep them optional, that's why the log tells if it misses blkid.
Actually it doesn't. And it's only automatically selected if the base
block-mount package is selected, so it is optional, but you don't have
to worry about individual dependencies, and things work as expected
without special effort out of the box.
it does, for a good reason, functions/block.sh issues a log message if
blkid is missing, but uuid is used. I don't see how to separate a base
block-mount package, because the majority is replacing old mounting
routines.
I'd expect the new functionality to split in something like
base-mount (which would be of package base-files because it replaces the
old fstab mounting and is therefore essential, consisting of the files
you put in buildroot/package/base-files except of the hotplugd stuff)
menuconfig->Base system->hotplugd-block-automount (automount files, to
enable automount feature)
menuconfig->Base system->hotplugd-block-fsck (to enable fsck on hotplug
events)
I'd suggest to put all hotplugd functionality in
buildroot/package/hotplugd-block. The hotplugd-block Makefile would
contain the package definitions mentioned above.
2) It should be possible to pull in the dependencies for say
block-blkid, from the base system menu (device-dependent submenu),
rather than having to hunt down, say, blkid
Sorry, not sure what you mean. Could you explain by example?
Base System|Device Dependent
should have packages such
block-meta-blkid, that has the dependencies that pull in blkid and
block-blkid (the package with the blkid mount stuff).
Why is this submenu 'Device Dependent' needed? What does it tell the user?
I see two solutions to this:
If we want to keep it simple and small it might make sense to simply
activate busybox's blkid per default. Have to doublecheck the size
increase though.
More elaborate could be, a basefiles subpackage setting
menuconfig->Base system->basefiles
[ ] support mount by uuid or label
. But maybe this is too much. I'd make it depending on the size increase
above.
me neither ;) .. but seriously. Circular dependencies only mean that
somebody did not look deep enough into setting them properly.
Not true, with the limited dependency language we have.
Show me an example that is not solvable.
packages that supply block devices: usb-storage, sdcard, ...
autoselect
packages that are needed to use these: e.g. block-mount
block-mount is *required* to use usb, it's just nice to have. That's
why profile selection not autoselect.
What do you mean?
block-mount is *required* to use usb,
or
it's just nice to have
?
In my understanding I distinguish between basefile-block-(mount,fsck(
and the hotplugd-block-(automount,fsck). The basefile functionality is
there anyway, the hotplugd is optional. Actually users do not need
automounting to use usb storage devices. They can use the terminal to
mount and stuff. But as hotplugd-automounting wasn't optional before on
second thought I'd vote for activating it by default, but make it not
depending on anything or anything depending on it.
.. what do you think, ede
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
