On Thu, May 6, 2010 at 11:39 AM, Bastian Bittorf <[email protected]> wrote: > * yann lopez <[email protected]> [06.05.2010 11:20]: > >> Let me know, if you'd like to commit it. > > + elif echo "$cardinfo" | grep huawei; then > > please use 'echo xy | grep -q huawei' > > or better define > > is_huawei () > { > local CARDINFO="$1" > > case "$CARDINFO" in > *huawei*) return 0 ;; > *) return 1 ;; > esac > } > > and > > elif is_huawei; then > ... > > > > bye, Bastian
Thanks your feedback, I copied the same pattern as for Option/Novatel. Find in attachment the modifications you have suggested. Yann
huawei_mode_selection.patch
Description: Binary data
_______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
