Hi Jonas On Sun, Aug 15, 2010 at 20:38, Jonas Gorski <[email protected]> wrote: > Hello, > > some (more or less) generic comments: > > On 14 August 2010 10:39, Luis Correia <[email protected]> wrote: >> (...) >> --- target/linux/ramips/rt305x/config-2.6.32 (revision 22631) >> +++ target/linux/ramips/rt305x/config-2.6.32 (working copy) >> @@ -149,8 +149,6 @@ >> CONFIG_TRAD_SIGNALS=y >> # CONFIG_TREE_PREEMPT_RCU is not set >> CONFIG_TREE_RCU=y >> -# CONFIG_USB_ARCH_HAS_EHCI is not set >> -# CONFIG_USB_ARCH_HAS_HCD is not set >> -# CONFIG_USB_ARCH_HAS_OHCI is not set > > This part looks good. > >> +CONFIG_USB_ARCH_HAS_HCD=y > > This shouldn't be needed as the generic/config-2.6.32 already has it. > >> (...) >> --- target/linux/ramips/rt305x/config-2.6.34 (revision 22631) >> +++ target/linux/ramips/rt305x/config-2.6.34 (working copy) >> @@ -19,7 +19,7 @@ >> CONFIG_CC_OPTIMIZE_FOR_SIZE=y >> CONFIG_CEVT_R4K=y >> CONFIG_CEVT_R4K_LIB=y >> -CONFIG_CMDLINE="console=ttyS1,57600 rootfstype=squashfs,jffs2" >> +CONFIG_CMDLINE="console=ttyS1,57600 rootfstype=squashfs,jffs2 > > This looks broken. Why do you remove the quotation mark at the end? > >> (...) >> +CONFIG_NOP_USB_XCEIV=y > > Is this needed for USB in general or just for OTG? And any reason for > including it in the kernel and not building it as a module? And why > only .34 and not also for .32? > >> (...) >> -# CONFIG_USB_ARCH_HAS_EHCI is not set >> -# CONFIG_USB_ARCH_HAS_HCD is not set >> -# CONFIG_USB_ARCH_HAS_OHCI is not set >> +CONFIG_USB_ARCH_HAS_HCD=y > > Same comment as for config-2.6.32. > >> +CONFIG_USB_GADGET=y >> +CONFIG_USB_GADGET_DUALSPEED=y >> +CONFIG_USB_GADGET_R8A66597=y >> +CONFIG_USB_GADGET_SELECTED=y >> +CONFIG_USB_GADGET_VBUS_DRAW=2 >> +CONFIG_USB_GPIO_VBUS=y >> +CONFIG_USB_MASS_STORAGE=y >> +CONFIG_USB_OTG_UTILS=y >> +CONFIG_USB_R8A66597=y > > Any reason for putting them into the kernel? Why not as separate > kmod-packages? Not everyone needs it, and it takes precious space. > >> (...) >> +# CONFIG_USB_ZERO is not set > > Same as above. > >> (...) > > Regards, > Jonas
I'll send a different patch, as this one is (stupid) and doesn't do the job correctly. After all, what's really needed is to remove all the existing cruft about USB and add 3 lines or so. Luis Correia _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
