Hello Sebastien, On Tuesday 17 August 2010 10:08:51 Sebastien Decugis wrote: > Hello Florian, > > > I got a couple of comments on it: > > > > - what about packaging the SCTP kernel module in > > package/kernel/modules/netsupport.mk instead? > > > > What about you submit the makefile for inclusion in the repository > > directly? > > I'd be happy with both changes :) > I chose this way so far so that a user can get SCTP support without > modifying her OpenWRT tree; but in order to get SCTP integrated > upstream, I am very fine to change the structure.
This is definitively the approach we prefer. Enabling SCTP or not in the kernel is then an user decision only. > > I was not so sure that it would be eventually merged (probably not many > packages would use SCTP currently), that's why I chose this structure > for my initial work. > > Should I rewrite as you suggest and then submit as a patch ? What is the > prefered way to submit this? (I am very new to OpenWRT, sorry). The prefered way to submit this would be to send two separate patches: - one which adds kmod-sctp to package/kernel/modules/netsupport.mk (against trunk) - a second which adds sctp to packages/net/sctp (against packages) Thanks! -- Florian _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
