Hi Gerrit, great to see some progress on the DockStar front :)
On 21 August 2010 22:13, Gerrit Visser <[email protected]> wrote: > Presently there is a default target for the Sheevaplug. The Seagate Dockstar > is similar but due to kernel differences I separated into 2 Targets: > GlobalScale and CloudEngines, each with one Profile for now. Someone is > already working on GuruPlug for OpenWRT, that would be another Profile under > GlobalScale. GlobalScale manufactures GuruPlug, GuruPlug Plus, Sheevaplug. > CloudEngines manufactures PogoPlug V1 and V2, Seagate Dockstar (aka > Redstone) and perhaps others. I'm not quite convinced having a subtarget for each device is a good idea. The differences are quite small, and most can be detected at run time. Having a generic image that boots fine on most devices would be better in my opinion, since you can't accidentally flash the wrong one. Also maintaining one config file instead of many is easier. Regarding the DockStar, run time detection should be easy, too. As far as I can see, one has to set the arcNumber anyways to get linux to boot. Using the newly assigned id 2998 for the DockStar should be sufficient for the kernel to automatically detect it as a DockStar. Now on to the code (I omitted the config files for now): > Index: target/linux/kirkwood/files/arch/arm/mach-kirkwood/dockstar-setup.c > =================================================================== > --- target/linux/kirkwood/files/arch/arm/mach-kirkwood/dockstar-setup.c > (revision 0) > +++ target/linux/kirkwood/files/arch/arm/mach-kirkwood/dockstar-setup.c > (revision 0) > @@ -0,0 +1,150 @@ > +/* > + * arch/arm/mach-kirkwood/dockstar-setup.c > + * > + * Marvell SheevaPlug Reference Board Setup This should be DockStar, too ;) > (...) > + > +MACHINE_START(DOCKSTAR, "Seagate FreeAgent Dockstar") > + /* Maintainer: shadi Ammouri <[email protected]> */ Unless you asked him to maintain it and he agreed, you should probably remove the comment (or add yourself if you want to maintain it). > +diff -urN a/arch/arm/tools/mach-types > ./linux-2.6.30.10-dockstar/arch/arm/tools/mach-types > +--- a/arch/arm/tools/mach-types 2009-12-04 01:00:07.000000000 -0500 > ++++ b/arch/arm/tools/mach-types 2010-08-12 21:47:23.000000000 -0400 > +@@ -2085,6 +2085,7 @@ > + gene100 MACH_GENE100 GENE100 > 2095 > + as353x MACH_AS353X AS353X > 2096 > + sheevaplug MACH_SHEEVAPLUG SHEEVAPLUG 2097 > ++dockstar MACH_DOCKSTAR DOCKSTAR 2097 Now sheevaplug and dockstar have the same machine number, won't this produce some kind of conflict? Also, according to <http://www.arm.linux.org.uk/developer/machines/> the correct number would be 2998, not 2097. > Index: target/linux/kirkwood/dockstar-setup.c > =================================================================== > --- target/linux/kirkwood/dockstar-setup.c (revision 0) > +++ target/linux/kirkwood/dockstar-setup.c (revision 0) I guess this was accidentally included. > Index: target/linux/kirkwood/Makefile > =================================================================== > --- target/linux/kirkwood/Makefile (revision 22691) > +++ target/linux/kirkwood/Makefile (working copy) > @@ -17,6 +18,6 @@ > > KERNELNAME:="uImage" > > -DEFAULT_PACKAGES += > +DEFAULT_PACKAGES +=ntpclient That belongs to target/linux/kirkwood/CloudEngines/profiles/100-Dockstar.mk. Currently you are adding it also to the Sheevaplug, which doesn't need it to keep the time. Regards, Jonas _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
