Hi Jonas Given that lars has entered 22765 into the repository, is there any point to me continuing?
BTW, the way Dockstar was added in that patch in fact replaces the Sheevaplug configuration. The addition (patch 22764) to u-boot is also not scaling, it uses Marvell as the board name while it should be Dockstar? Regards, Gerrit Visser Message: 4 Date: Sat, 21 Aug 2010 21:24:59 -0400 From: "Gerrit Visser" <[email protected]> To: <[email protected]> Subject: Re: [OpenWrt-Devel] [PATCH] Modifying target/linux/kirkwood to add Dockstar Message-ID: <001f01cb4198$d63c6db0$82b549...@ca> Content-Type: text/plain; charset="us-ascii" Hi Jonas Thank you for your review. I worked on the 'generic/runtime detection/code selection for a while but reverted to the approach used previously. My dilemma is that I have only 1 Dockstar, no other devices. Thus it is difficult to test what I create. I do completely agree that the present approach doesn't scale. Eric, who submitted the new ID request, had not received a response that this new ID was in fact accepted. So I used 2097 in my patch. If that new number is indeed the official one, then I will gladly update the patch. I would like to propose that we move ahead (after I make your other suggested changes/fixes) so that people can get moving with OpenWRT on Dockstar, et al In parallel I am happy to dust off my C coding skills to make a stab at the 'right' solution. Jow previously sent me a template to base a possible solution on. Now that I know more about OpenWRT, linux kernels and the build mechanism I can move forward some more on the real solution. I do however feel that this could be an iterative solution, where we get people onto OpenWRT sooner using the non-optimal approach (which FWIW is how mainline linux is going (https://forum.openwrt.org/viewtopic.php?pid=115487#p115487) Re: multiple targets and profiles, there seem to be significant differences at the hw level on these boards. CloudEngines boards do not have as default a u-boot that supports usb. The Dockstar has no sata or mmc/sd interface while others do, Guruplugs have wireless, etc. This is why I concluded that the two Sub Targets with relevant Profiles would be a best fit for supporting the variations. I spent considerable effort to make it work with just Profiles but because target.mk doesn't support 'config-<profile> inputs it wouldn't work. This capability seems to be alluded to in target.mk (in dumpinfo). I have 2 more dockstars on the way, this will let me move forward with my real goal (replacing my Asterisk system with this plus FreeSWITCH) as well as working on the runtime setup replacement for the present ,xxx.-setup explosion. Regards, Gerrit Visser _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
