Le mardi 12 octobre 2010 à 19:57 +0200, Michael Büsch a écrit : > On Tue, 2010-10-12 at 19:41 +0200, Benjamin Cama wrote: > > * Your openssl added dependency is wrong: it is optionnaly selected when > > you enable the SSL module. See Config.in. Is there something wrong with > > that that you found ? > > It is incorrect to select a package from a Config.in file, because that > violates build dependencies. (Build failed for me).
Mmh, okay, but does it do that after a package/nginx/clean ? I think this may be due to the fact that I changed the package to optionnal modules, and the SSL one used to be built-in, but now it's not by default. OTOH, I know this doesn't look "right" in a "nicely described dependencies" way. > One major problem is that "select PACKAGE_libopenssl" does not affect > build ordering. This is probably fixable by adding a PKG_BUILD_DEPENDS. > The package probably also needs a few PKG_CONFIG_DEPENDS. I'm not sure > on this. I think that, from what I understand, a PKG_CONFIG_DEPENDS is actually needed for this package (on CONFIG_PACKAGE_libopenssl). But how do you do the PKG_BUILD_DEPENDS bit when the symbol is in a Config.in ? This is why I Cc'ed the list: does someone have an advice on this ? > So, yeah, the new +libopenssl dependency seems wrong, but we certainly > need a build dependency (probably conditional on the config option) to > openssl. True. > > * As Florian said for other packages, I'm not sure that PKG_RELEASE need > > to be increased. > > Well, I added a dependency, so I'm pretty sure a bump is needed. I thought that only added/removed files needed such a bump. Florian, do you confirm that ? Is this somewhere on the wiki ? (where I surely should have searched more thoroughly…) Regards, benjamin _______________________________________________ openwrt-devel mailing list openwrt-devel@lists.openwrt.org https://lists.openwrt.org/mailman/listinfo/openwrt-devel
