On 13/11/10 12:33, Daniel Dickinson wrote:
> On Fri, 12 Nov 2010 21:29:08 +0100
> [email protected] wrote:
>
>> From: Mark Vels <[email protected]>
>>
>> This typo fix solves at least the following warning:
>> sysinit: WARNING: /lib/functions/fsck not found
>> but probably also some functionality that uses the functions
>> from this include file.
>>
>> Signed-off-by: Mark Vels <[email protected]>
>> ---
>> package/block-mount/files/fsck.sh | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/package/block-mount/files/fsck.sh
>> b/package/block-mount/files/fsck.sh index 3011160..047bdd3 100644
>> --- a/package/block-mount/files/fsck.sh
>> +++ b/package/block-mount/files/fsck.sh
>> @@ -30,5 +30,5 @@ libmount_fsck() {
>>
>> libmount_known_fsck=""
>>
>> -pi_include /lib/functions/fsck
>> +pi_include /lib/functions/fsck.sh
>>
>
> Sorry, that's not right. /lib/functions/fsck is a directory that only
> exists if some fsck program is installed (e.g. e2fsprogs).
>
Yep, I was a little quick with my conclusion here.
I'm just using the block-mount package and no fsck stuff. Therefore IMHO I
shouldn't be bothered with a warning about a
perfectly normal situation.
If I do a grep on that path I see that currently only see e2fsprogs using that
path and I'm not using that.
Can we add something like
[ -d /lib/functions/fsck ] && pi_include /lib/functions/fsck
to package/block-mount/files/fsck.sh to suppress the invalid warning in case
/lib/functions/fsck does not exist?
Just let me know, I'll prepare a patch then ..
Mark
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
