Hi, On Tue, Dec 14, 2010 at 10:14:46AM -0800, Bogdan Giuglea wrote: > -append args "-p 5000 -U" > +if [ "$upnp" = "1" ]; then > +append args "-p 5000" > +echo enable_upnp=yes >> /tmp/miniupnpd.conf & > +else > +echo enable_upnp=no >> /tmp/miniupnpd.conf & > +fi
Don't run "echo" commands in the background. There is no benefit to it,
it needs more resources (extra shell) and will create potential race
conditions.
IOW: the "&" is completely unnecessary and potentially dangerous.
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany [email protected]
fax: +49-89-35655025 [email protected]
pgpKSvs89AIM0.pgp
Description: PGP signature
_______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
