Hi Jonas,

It's nice to see someone working supporting these new devices. I am also
planing to buy such a device, but they are expensive (device with usb
and gigabit switch are starting with 70 Euro, include shipping (e.g.
Netgear WNR3500L) and basic versions with 44 Euro (e.g. ASUS RT-N12).

On 12/18/2010 02:09 PM, Jonas Gorski wrote:
> Okay,
> 
> the patch(es) can be found at
> <http://page.mi.fu-berlin.de/jgorski/openwrt/bcm47xx/>, either as a
> patch against trunk or as individual patches against the linux-mips
> git tree.

The patches look pretty good for now. I have not look too closely into them.

In 0008-SSB-Add-support-for-the-PMU-of-newer-Broadcoms.patch you are
checking for 47162 shouldn't it be 0x47162 or did Broadcom some new
strange thing.

For the big patches it would be easier to review if one patch just
reorders the code, like putting it into the new functions in
0002-SSB-Modify-core-scan.patch and an extra patch for adding some new
features or for doing some real changes.

> Note that the OpenWrt patch removes two patches that get replaced by
> these patches. Also I didn't make sure it doesn't break anything else.
> 
> Also when testing you might want to remove the
> "016-MIPS-BCM47xx-Remove-CFE-console.patch" to be able to enable early
> printk.
You have to remove this patch for early printks did not
014-MIPS-BCM47xx-Setup-and-register-serial-early.patch helped? Or does
this needed some functionality in ssb that is not implemented for these
devices?
> 
> Jonas
> 
> @Hauke: I had to remove the revision check for the num_cores detection
> since reading the register hangs (at least) the BCM4716.
> If we keep that part of the code, we might want to first check if
> there's a known chipid => num_cores mapping, and if not read the
> number of cores from the register without checking the core revision.
Hopefully there is some other register that is indicating if we could
read out this register or not.

Are there big changes between 4716 and 47162?

Hauke
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to