Thanks for the fixes (and Felix also of course!)
Now everything build again happily for my target :)

Maarten

On Sat, 2011-04-02 at 21:35 +0200, Hauke Mehrtens wrote:
> Hi Maarten,
> 
> Yes I should read it more carefully or test it. ;-) Why the hell is then
> DEPENDS file at the end of the block?
> 
> Felix fixed this already when the module is build into the kernel in
> r26406, when building it as a module it is now fixed in r26413.
> 
> Hauke
> 
> On 04/02/2011 06:12 PM, Maarten Bezemer wrote:
> > I see the wrong patch got applied before my email arrived, so I created
> > a new patch to fix the it
> > 
> > 
> > 
> > 
> > On Sat, 2011-04-02 at 18:00 +0200, Maarten Bezemer wrote:
> >> Hello,
> >>
> >> It took me a while to figure out why your patch was not working, but it
> >> adds a second DEPENDS, which is overridden with the original one.
> >> So your patch needs to be updated a bit.
> >>
> >> Another thing is, I did not have the hardware crypto enabled (as I
> >> did/do now know that my WRT350Nv2 has hardware crypo support).
> >>
> >> So your patch does not help fixing the problem when
> >> CONFIG_kmod-crypto-mv-cesa is deselected. (in OpenWRT config)
> >> In this situation the config-default for orion (in target/linux/orion)
> >> selects CONFIG_CRYPTO_DEV_MV_CESA and not CONFIG_CRYPTO_HASH
> >>
> >> So I guess you need to update config-default in your patch as well?
> >>
> >> Greetings,
> >>   Maarten
> >>
> >> On Sat, 2011-04-02 at 17:20 +0200, Hauke Mehrtens wrote:
> >>> Hi,
> >>>
> >>> The attached patch should fix the problem.
> >>> mv_remove and mv_probe are from drivers/crypto/mv_cesa.c and this driver
> >>> depends on crypto_hash.ko.
> >>>
> >>> Please test this and report the results , if it fixes the problem I will
> >>> commit this. This has nothing to do with an update to kernel 2.6.37.6,
> >>> what is blocking 2.6.37.6, if nothing then I would like to add this patch.
> >>>
> >>> Hauke
> >>>
> >>> On 04/02/2011 05:04 PM, Maarten Bezemer wrote:
> >>>> On Sat, 2011-04-02 at 14:51 +0200, Felix Fietkau wrote:
> >>>>> On 2011-04-02 2:31 PM, Maarten Bezemer wrote:
> >>>>>> When I select CONFIG_CRYPTO_HASH in the kernel config, everything 
> >>>>>> works!
> >>>>> Should be fixed in r26402
> >>>>
> >>>> Thanks for putting effort into this problem.
> >>>> But unfortunately, this change does not select CONFIG_CRYPTO_HASH.
> >>>>
> >>>> Orion does not have CONFIG_OCF_OCF and thus CONFIG_OCF_CYRPTOSOFT
> >>>> selected..
> >>>> If I select it manually (by changing the config-default of the orion
> >>>> target)
> >>>>
> >>>> Everything works, so I suppose another update is required for the orion
> >>>> target default config? Or is it unwanted to have this enabled by
> >>>> default?
> >>>>
> >>>> Thanks again,
> >>>>   Maarten

_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to