Hello Johannes, On 11 April 2011 12:27, Johannes Weißl <[email protected]> wrote: > Another question regarding the Makefile: The current version depends on > libmad, libvorbisidec and libflac. Cmus supports many more input/output > plugins. What is the best way to handle that? > 1. Just depend on the most common ones (current version). > 2. Depend on no library, but set PKG_BUILD_DEPENDS. This way all plugins > are installed (really small .so files, 4-20KiB), and the user can > decide which libraries to install (like Recommends in apt) for > himself. > 3. Use Config.in like for libffmpeg. > > What do you suggest?
If these are indeed plugins and cmus also runs without them, then you could pack the indivial plugins in extra packages, and let the plugin packages depend on the libraries they use. Also generally, can you make this a patch against packages/ instead of single files? It makes testing easier. See https://dev.openwrt.org/wiki/SubmittingPatches :) Regards Jonas _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
