It is been almost a week without responses, does that mean that the patch is good enough now and ready to be applied? Or am I being too impatient? ;)
Maarten On Mon, 2011-04-11 at 23:50 +0200, Maarten Bezemer wrote: > Here is my second try of the patch updating samba3 to version 3.0.37 > (highest 3.0.x version) > > > The 10MB originated due to the fact that I had the CONFIG_SAMBA3_DEBUG > enabled... Nonetheless, I found an updated AVM patch and added it, > resulting in a few 100kB reduction. :) > > File sizes (in bytes) with all reduction options enabled: > 961075 nmbd > 2968599 smbd > 1756550 smbpasswd > > > As it is my first big patch, I still like to tell a bit more what I did > in order to see whether my steps/thoughts were ok: > - The configure stage now makes use of the configure script of samba, to > do so these parts got changed: > - Updated the avm patch, found a nicely working version at > http://freetz.org/browser/trunk/make/samba/patches/110-samba_avm.patch > Only updated a few small things: > - At freetz they liked /var/media/ftp to share by default, which we > do not have... Resulting in a run-time error > - Same for /var/tmp instead of /tmp > - OpenWRT related paths are used as input for configure script if > possible, otherwise Makefile.in is patched (patch 120) > - Fixed owrt_smbpasswd as it contained a function which got included by > this samba version (patch 130) > - mmap is not available according to configure so a patch for this is > not required (removes patch 140) > - Added a patch to have the configure script accept a second 'site > file', which contains some available features which are not detected > due to cross-compilation > - Other patches got (mostly) refreshed > > - This version depends on libpopt > > - Enabled parallel building (but unfortunately an ugly hack was added, > as some generated files would be missing otherwise), it saves lots of > time... > > - Required configure feature which are undetectable due to cross > compilation are cached in files/samba-site > > - Added some options to disable extra features to save space > > - Added MAX_DEBUG_LEVEL=2 macro when debugging is turned of (saves about > 1MB total for the 3 binaries!) > > I have tested the package on my router, file sharing works (other things > I could not test) > > I am unsure about RPC, when looking at the compilation output I seems > that RPC is still being compiled? Even though I explicitly disabled it > in the configure script. > > > Please take a look at my changes and please provide some feedback if > possible. > > Thanks, > Maarten > > _______________________________________________ > openwrt-devel mailing list > [email protected] > https://lists.openwrt.org/mailman/listinfo/openwrt-devel _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
