On 29/05/11 19:14, Philip Prindeville wrote:
> Minor comment. It's my understanding that gmake will fork/exec commands 
> directly if it doesn't detect any meta-characters, thereby saving a fork/exec 
> pair of $(SHELL) to interpret them. In this case:
> 
>> +    $(CP) $(PKG_INSTALL_DIR)/usr/lib/ipsec/{openac,pki,scepclient} 
>> $(1)/usr/lib/ipsec/
> 
> it would be a lot more efficient to just write out both pathnames as absolute 
> (easier to grep through logs, too).
> 
> -Philip
> 

i disagree, the proposed call is consistent with how most other owrt
Makefiles are written
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to