Hi,

this patch was mangled by your email program; it replaced all tabs
with spaces. Also please don't use quoted printable but plaintext
(even if patchwork is able to cope with that).

Some specific comments:

On 30 May 2011 14:13, Adam Chasen <[email protected]> wrote:
> Signed-off-by: Adam Chasen ([email protected])

Please use <> for your email address.

> Index: libs/libao/Makefile
> ===================================================================
> --- libs/libao/Makefile (revision 27025)
> +++ libs/libao/Makefile (working copy)
> @@ -8,12 +8,12 @@
>  include $(TOPDIR)/rules.mk
>
>  PKG_NAME:=libao
> -PKG_VERSION:=0.8.8
> +PKG_VERSION:=1.1.0
>  PKG_RELEASE:=1
>
>  PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz
>  PKG_SOURCE_URL:=http://downloads.xiph.org/releases/ao/
> -PKG_MD5SUM:=b92cba3cbcf1ee9bc221118a85d23dcd
> +PKG_MD5SUM:=2b2508c29bc97e4dc218fa162cf883c8
>
>  PKG_FIXUP:=libtool
>  PKG_INSTALL:=1
> @@ -55,6 +55,8 @@
>  define Package/libao/install
>        $(INSTALL_DIR) $(1)/usr/lib
>        $(CP) $(PKG_INSTALL_DIR)/usr/lib/libao.so.* $(1)/usr/lib/
> +       $(INSTALL_DIR) $(1)/usr/lib/ao/plugins-4
> +       $(CP) $(PKG_INSTALL_DIR)/usr/lib/ao/plugins-4/lib*.so

Oops, this isn't just a version bump anymore.

Were these plugins already present in 0.8.8?
Is the lib usable wthout them? Then it might be worth creating an
extra package them separately.
What is the size impact of adding them?


Jonas
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to