On 2011-06-30 2:39 PM, Philip Prindeville wrote:
On 6/29/11 11:35 PM, Felix Fietkau wrote:
 On 2011-06-30 2:22 PM, Philip Prindeville wrote:
 uClibc provides strlcpy() but e/glibc don't.  Thus we need to link against 
libbsd in those cases.

 It was suggested that the extra values be added to the end of the config.sh 
file, but (a) I didn't want
 to introduce a new mechanism, and (b) someone might expect the alphabetical 
order of variables in the
 config.sh file to be continued, and hence not be look at the end of the file 
for the additional values.

 Also one of those variables already is partially initialized, so doing:

 perllibs="$perllibs ..."

 would be required, which is risky.
 Why is it risky?

 - Felix

I was thinking that there might be re-interpretation of meta characters in 
substituted value.
Characters in $perllibs are handled correctly by the shell. Only what gets added afterwards needs to be checked for special characters. Since that data is provided by the build system, this should not be a problem.

- Felix

_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to