Ok. I just tried to unify style of this file, and wasn't planning tabs<->spaces holy-war :-) Although, both approaches can be found all over the code and there is no specific guidelines on subject.
Note, there is at least one change not related to styling: > - --disable-acl-support \ > + --disable-acl-support On Fri, Sep 30, 2011 at 14:48, Florian Fainelli <[email protected]> wrote: > Hello, > > On Monday 29 August 2011 22:09:35 [email protected] wrote: > > From: "Eugene San (eugenesan)" <[email protected]> > > > > > > Signed-off-by: Eugene San (eugenesan) <[email protected]> > > --- > > net/rsync/Makefile | 26 +++++++++++++------------- > > 1 files changed, 13 insertions(+), 13 deletions(-) > > > > diff --git a/net/rsync/Makefile b/net/rsync/Makefile > > index 46670e5..f6d8eb1 100644 > > --- a/net/rsync/Makefile > > +++ b/net/rsync/Makefile > > @@ -21,20 +21,20 @@ PKG_BUILD_PARALLEL:=1 > > include $(INCLUDE_DIR)/package.mk > > > > define Package/rsync > > - SECTION:=net > > - CATEGORY:=Network > > - SUBMENU:=File Transfer > > - TITLE:=Fast remote file copy program (like rcp) > > - DEPENDS:=+libpopt > > - URL:=http://rsync.samba.org/ > > + SECTION:=net > > + CATEGORY:=Network > > + SUBMENU:=File Transfer > > + TITLE:=Fast remote file copy program (like rcp) > > + DEPENDS:=+libpopt > > + URL:=http://rsync.samba.org/ > > endef > > > > define Package/rsyncd > > - SECTION:=net > > - CATEGORY:=Network > > - SUBMENU:=File Transfer > > - TITLE:=Rsync daemon > > - DEPENDS:=+rsync > > + SECTION:=net > > + CATEGORY:=Network > > + SUBMENU:=File Transfer > > + TITLE:=Rsync daemon > > + DEPENDS:=+rsync > > endef > > > > define Package/rsync/description > > @@ -54,7 +54,7 @@ CONFIGURE_ARGS += \ > > --disable-debug \ > > --disable-locale \ > > --disable-xattr-support \ > > - --disable-acl-support \ > > + --disable-acl-support > > > > define Package/rsync/install > > $(INSTALL_DIR) $(1)/usr/bin > > @@ -68,7 +68,7 @@ define Package/rsyncd/description > > endef > > > > define Package/rsyncd/conffiles > > -/etc/rsyncd.conf > > + /etc/rsyncd.conf > > endef > > > > define Package/rsyncd/install > > The prefered way of writing a Makefile is how it is right now. Inserting > tabs > instead of 2 spaces is not what we generally have. > -- > Florian >
_______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
