On Tue, Nov 15, 2011 at 11:46 PM, Peter Wagner <[email protected]> wrote:
> Hi {Nico} and the List,
>
> i think this is a good idea. But some other things i would change too. The
> default homefolder of tor is /var/lib/tor (tor creates only files in this
> folder) so the homedir in /etc/passwd should be changed to that directory too.
> And as every program creates a pid in /var/run without subfolders the touch &
> chown approch of a file is much nicer - imho. Also if a user would change the
> the pid to /var/run/tor.pid in torrc tor would still not start. As the folder
> is allready there it wouldnt be created and tor has no write previleges to
> write into this folder. (if you use my updates patch - tor_v1.patch)
>
> I think tor should create a pid in /var/run without a subfolder and setting
> the --PidFile option that is also needed with your updated approach (see
> tor_v1.patch). i would still prefer v2 patch as it ignores the value of torrc
> and just creates a file in /var/run. it is simpler and as nearly no user cares
> about the pid file it even uses less memory as no dir is created ;) and the
> init file is much smaller and simpler.
>
> I would perfer that tor gets stopped on shutdown because when extroot is used
> it will result in an unclean umounted fs.
>
> What do you think? :)
Sold :)
I'll add a note in the config-file stating the pid-file location is fixed
--
-{Nico}
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
