On Fri, Nov 25, 2011 at 6:45 PM, Mark Mentovai <[email protected]> wrote: > Gabor Juhos wrote: >> 2011.11.16. 21:20 keltezéssel, Petri Rosenström írta: >>> This fixes the machine name in /proc/cpuinfo and luci status page machine >>> name. >>> >>> Signed-off-by: Petri Rosenström <[email protected]> >> >> Applied, thanks! > > I don't think this patch is a great idea. There are no differences > between the boards in the WNDR3700v2 and WNDR3800. The only hardware > difference is that the latter has more RAM. I don't think that baking > this information into the OpenWRT image or differentiating between the > two models in this way serves any useful purpose. >
Hi, I think it is useful because it adds the specific board information about WNDR3800 (e.g. the name WNDR3800 on status page or /proc/cpuinfo show correct board name). I think that this information is important and it should be available. Consider the following, someone buys a wndr3800 and flashes it with the current Openwrt image (it works perfectly except the user thinks that Openwrt doesn't support wndr3800 fully because it doesn't recognize the device). The user doesn't know how luci or /proc/cpuinfo gathers the information. The user probably assumes that there is something wrong about OpenWRT. Then on the other hand what harm does the patch? I think that when it gives users correct information about the is more important. But I should point out that I don't maintain OpenWRT :) btw. Do you (Mark) own the both devices? Have you (Mark) checked that they are the same (only RAM diff)? I have *only* seen claims on some forums and I only own a wndr3800 so I can't say for sure. It seems like they are. But it would be nice to know for sure. -- Petri _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
