Ok, no probs.
Personally I prefer the trailing slash: it is explicit about indicating that 
the target is a directory.  Without the trailing slash, cp will happily succeed 
if $(1)/usr/lib happens to be a file.
Generally it looks like any given openwrt packages uses either one, or both 
conventions.

On 2012-02-15, at 1:59 AM, Alain Kalker wrote:

> Op 15-02-12 07:38, Alain Kalker schreef:
>> Please also install the header files (there are a lot of them, and 
>> hdhomerun.h includes almost all of the others) so I would like to suggest 
>> using a subdirectory) and the shared library in the staging dir, so other 
>> packages (like dvbhdhomerun, which I am working on) can use them, like so: 
>> 
>> define Build/InstallDev 
>>     $(INSTALL_DIR) $(1)/usr/include/hdhomerun 
>>     $(CP) $(PKG_BUILD_DIR)/*.h $(1)/usr/include/hdhomerun 
>> 
>>     $(INSTALL_DIR) $(1)/usr/lib 
>>     $(CP) $(PKG_BUILD_DIR)/libhdhomerun.so $(1)/usr/lib/ 
>> endef 
> -$(CP) $(PKG_BUILD_DIR)/libhdhomerun.so $(1)/usr/lib/ 
> +$(CP) $(PKG_BUILD_DIR)/libhdhomerun.so $(1)/usr/lib 
> 
> i.e. no need for that final slash, cleaner that way, sorry 
> 
> Kind regards, 
> 
> Alain
> _______________________________________________
> openwrt-devel mailing list
> [email protected]
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel

_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to