Op 15-02-12 05:49, Alain Kalker schreef:
The CMake template Build/Configure/Default assumes that CMakeLists.txt is
always in $(PKG_BUILD_DIR) , which leads to problems with packages which
have their source code in a subdirectory.
Fix this by honouring the value of $(CONFIGURE_PATH) , similar to the generic
Build/Configure/Default .
Stepping back for a moment, I am wondering if even CONFIGURE_PATH is the
right choice.
Since in this case the command to configure the build isn't really
'configure' but 'cmake', the proper name should probably be CMAKE_PATH .
Before rushing off and doing yet another version of the patch, let's
consider this one step further.
Qt uses 'qmake' (well, actually Qt 4 uses CMake, but let's stick with it
for the sake of argument), so: use QMAKE_PATH. Yet other packages may
use 'scons': use SCONS_PATH , etcetera, ad nauseum.
So, isn't it better to consider having a generic make variable to manage
all those cases?
Perhaps something like PKG_SRC_PATH makes sense? I do realize that the
PKG_* 'namespace' is already somewhat crowded, but I believe this
particular addition has some merit. Any comments or suggestions?
Kind regards,
Alain
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel
