Hi,

On 22 February 2012 11:03, Hanno Schupp <[email protected]> wrote:
> Signed-off-by: Hanno Schupp <[email protected]
>
> Index: package/iwinfo/src/iwinfo_wl.c
> ===================================================================
> --- package/iwinfo/src/iwinfo_wl.c      (revision 30668)
> +++ package/iwinfo/src/iwinfo_wl.c      (working copy)
> @@ -456,8 +456,8 @@
>  int wl_get_txpwrlist(const char *ifname, char *buf, int *len)
>  {
>        struct iwinfo_txpwrlist_entry entry;
> -       uint8_t dbm[8] = { 0, 6, 8, 10, 12, 14, 16, 18 };
> -       uint8_t mw[8]  = { 1, 3, 6, 10, 15, 25, 39, 63 };
> +       uint8_t dbm[8] = { 0, 6, 8, 10, 12, 14, 16, 18, 20, 22, 24};
> +       uint8_t mw[8]  = { 1, 3, 6, 10, 15, 25, 39, 63, 100, 158, 251};

Does this really work? Shouldn't the array size be increased to 11 (or
just removed) ...

>        int i;
>
>        for( i = 0; i < 8; i++ )

and the loop extended to these new values ... (probably best replaced
with ARRAY_SIZE())

>       *len = 8 * sizeof(entry);

and this also be increased?


Regards
Jonas
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to