Can we avoid whitespace-only changes?

They increase effort to keeping up with what's been committed without adding 
any value, and I find it takes twice as long to search them to find out what, 
if anything, they functionally change.

I literally have to read it a second time to figure out that they don't 
introduce any functional value... just to be sure I didn't miss anything hidden 
in there on the first reading.

Thanks.


On 3/8/12 6:11 PM, [email protected] wrote:
> Author: swalker
> Date: 2012-03-09 02:11:17 +0100 (Fri, 09 Mar 2012)
> New Revision: 30858
> 
> Added:
>    packages/utils/dosfstools/files/
>    packages/utils/dosfstools/files/dosfsck.sh
> Modified:
>    packages/utils/dosfstools/Makefile
>    packages/utils/dosfstools/patches/002-linux_26_headers.patch
> Log:
> [packages] dosfstools: update to 3.0.12, add fsck script (#10697)
> 
> 
> [snip]
> Modified: packages/utils/dosfstools/patches/002-linux_26_headers.patch
> ===================================================================
> --- packages/utils/dosfstools/patches/002-linux_26_headers.patch      
> 2012-03-08 10:21:14 UTC (rev 30857)
> +++ packages/utils/dosfstools/patches/002-linux_26_headers.patch      
> 2012-03-09 01:11:17 UTC (rev 30858)
> @@ -4,31 +4,29 @@
>      can be found in /usr/share/common-licenses/GPL-3 file.
>   */
>   
> --# include <asm/types.h>
> +-#include <asm/types.h>
>  +#include <linux/types.h>
>   
>   #ifndef _COMMON_H
>   #define _COMMON_H
>  --- a/src/dosfsck.h
>  +++ b/src/dosfsck.h
> -@@ -32,8 +32,8 @@
> - #define _LINUX_STRING_H_    /* hack to avoid inclusion of <linux/string.h>*/
> - #define _LINUX_FS_H             /* hack to avoid inclusion of <linux/fs.h> 
> */
> +@@ -31,7 +31,7 @@
> + #define _LINUX_STRING_H_    /* hack to avoid inclusion of <linux/string.h> 
> */
> + #define _LINUX_FS_H         /* hack to avoid inclusion of <linux/fs.h> */
>   
> --# include <asm/types.h>
> --# include <asm/byteorder.h>
> +-#include <asm/types.h>
>  +#include <linux/types.h>
> -+#include <asm/byteorder.h>
> + #include <asm/byteorder.h>
>   
>   #include <linux/msdos_fs.h>
> - 
>  --- a/src/file.c
>  +++ b/src/file.c
> -@@ -34,7 +34,7 @@
> - #define _LINUX_STRING_H_    /* hack to avoid inclusion of <linux/string.h>*/
> - #define _LINUX_FS_H             /* hack to avoid inclusion of <linux/fs.h> 
> */
> +@@ -33,7 +33,7 @@
> + #define _LINUX_STRING_H_    /* hack to avoid inclusion of <linux/string.h> 
> */
> + #define _LINUX_FS_H         /* hack to avoid inclusion of <linux/fs.h> */
>   
> --# include <asm/types.h>
> +-#include <asm/types.h>
>  +#include <linux/types.h>
>   
>   #include <linux/msdos_fs.h>
> @@ -49,7 +47,7 @@
>   #include <time.h>
>   #include <errno.h>
>   
> --# include <asm/types.h>
> +-#include <asm/types.h>
>  +#include <linux/types.h>
>   
>   #if __BYTE_ORDER == __BIG_ENDIAN
> 
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to