Hi,

some comments

On 6 April 2012 13:17, Mike Brady <[email protected]> wrote:
> This patch updates avahi to latest version -- 0.6.31.

A reason why avahi should be updated would be nice (not necessary
though, since it's only a minor bump).

> It also adds a note to the description.
>
> Signed-off-by Mike Brady <[email protected]>
>
>
> Index: Makefile
> ===================================================================
> --- Makefile    (revision 31212)
> +++ Makefile    (working copy)

Please create the patch with the full path (I had to find the avahi
package first), it should be packages/libs/avahi/Makefile.

> @@ -15,13 +15,13 @@
>
>
>  PKG_NAME:=avahi
> -PKG_VERSION:=0.6.30
> -PKG_RELEASE:=4
> +PKG_VERSION:=0.6.31
> +PKG_RELEASE:=1
>
>
>  PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz
>  PKG_SOURCE_URL:=http://avahi.org/download/
> -PKG_MD5SUM:=e4db89a2a403ff4c47d66ac66fad1f43
> +PKG_MD5SUM:=2f22745b8f7368ad5a0a3fddac343f2d
>
>  PKG_BUILD_DEPENDS:=libexpat libdaemon libgdbm intltool/host libpthread dbus
>
> @@ -52,6 +52,9 @@
>  This kind of technology is already found in MacOS X
>  (branded 'Rendezvous', 'Bonjour' and sometimes 'ZeroConf')
>  and is very convenient.
> + .
> + Note: you should always do a "make clean" after changing
> + any avahi build settings.

Instead of adding this note, how about adding a PKG_CONFIG_DEPENDS
section which will trigger a rebuild of the package on configuration
changes.

See <https://dev.openwrt.org/browser/trunk/package/hostapd/Makefile#L25>
for an example.


Jonas
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to