Le 18/04/2012 23:17, Peter Naulls a écrit :
On 04/17/2012 11:15 AM, Mirko Vogt wrote:
Hey Emmanuel,

I levelled up all versions of eglibc to i's latest revisions of its
respective branches ( https://dev.openwrt.org/changeset/31300 ) and
therewith I guess broke eglibc version 2.12 which I'd like to purge out
anyway. Is there any reason for you to stay on 2.12 instead of 2.13?
If it id "because it doesn't/didn't work" please give it another try and
let me know.

Unless something has changed very recently, 2.12 and 2.14 builds have
been broken for as long as I've been looking at them, which is the
best part of a year.   Only 2.13 builds, and even then you still
need some additional e/glibc patches for the rest of the system
to work correctly.

https://dev.openwrt.org/ticket/9483

So, again.  Old versions of both eglibc and glibc need to be purged,
since they (a) are ancient (b) don't build (c) cause repeat
questions of exactly this type on this list.

Checked with 2.13, and it indeed works.

Regarding eglibc selection, it feels weird to me to be able to select
both a version AND a revision. If I want version 2.12, I will probably
stick to its corresponding revision. Same for 2.13 or 2.14. Worse,
it doesn't work as expected (violation of the principle of least
surprise): the revision does not change if I change the eglibc
version.

Should we limit the revision selection to the eglibc trunk version?
That would make much more sense IMHO, and that would minimize issues
that are related to version/revision conflicts (I suspect they are
quite hard to spot).

Something like:

-----8<-----------------------------------------------------------
Force the use of known revision for specific eglibc versions.
Eglibc revision can only be changed if the user selects the trunk
version.

Signed-off-by: Emmanuel Deloget <[email protected]>

Index: toolchain/eglibc/Config.in
===================================================================
--- toolchain/eglibc/Config.in  (révision 31345)
+++ toolchain/eglibc/Config.in  (copie de travail)
@@ -22,15 +22,19 @@

 endchoice

+config EGLIBC_TRUNK_REVISION
+       string
+       prompt "eglibc revision"
+       depends on TOOLCHAINOPTS && USE_EGLIBC && EGLIBC_VERSION_TRUNK
+       default "HEAD"
+
 config EGLIBC_REVISION
        string
-       prompt "eglibc revision"
        depends on TOOLCHAINOPTS && USE_EGLIBC
        default "14661" if EGLIBC_VERSION_2_12
        default "15508" if EGLIBC_VERSION_2_13
        default "16488" if EGLIBC_VERSION_2_14
-       default "HEAD"  if EGLIBC_VERSION_TRUNK
-       default ""
+       default EGLIBC_TRUNK_REVISION if EGLIBC_VERSION_TRUNK

 menu "eglibc configuration"
        depends on TOOLCHAINOPTS && USE_EGLIBC


_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to