On Wed, May 23, 2012 at 01:22:18AM +0100, Conor O'Gorman wrote: > On Wed, 2012-05-23 at 01:10 +0200, Luka Perkov wrote: > > Leds gpio values have changed since initial patch was contributed. I > > have double checked and this are correct values. > > > > This also enables uboot_env partition. > > And moves the linux partition, and removes the config partition,
I should have told that we dont need the board_config partition since wifi data is the same on all boards. > and the buttons settings have small adjustments. Yes - to match other lantiq mach-* files. > I would suggest a better title and description covering all changes. > Only mentioning the leds in the title is insufficient. It's the most important change in this patch and reason for sending it. I dont see the need to comment every line in basic patch like this. Luka _______________________________________________ openwrt-devel mailing list [email protected] https://lists.openwrt.org/mailman/listinfo/openwrt-devel
