-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

I copied & commented your patch inline below.

- --- /dev/null 2012-07-05 10:42:19.287097043 +0200
+++ package/libsocketcan/Makefile       2012-07-05 18:35:26.763462631 +0200
@@ -0,0 +1,62 @@
+#
+# Copyright (C) 2006-2012 OpenWrt.org

That should only be 2012

+#
+# This is free software, licensed under the GNU General Public
License v2.
+# See /LICENSE for more information.
+#
+
+include $(TOPDIR)/rules.mk
+
+PKG_NAME:=libsocketcan
+PKG_VERSION:=0.0.8
+PKG_RELEASE:=1
+
+PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.bz2
+PKG_SOURCE_URL:=http://www.pengutronix.de/software/libsocketcan/download/
+PKG_MD5SUM:=7fa608d46553c1e33b6b34cab0a83c00
+
+include $(INCLUDE_DIR)/package.mk
+
+define Package/libsocketcan
+  SECTION:=libs
+  CATEGORY:=Libraries
+  TITLE:=socketcan library
+  URL:=http://www.pengutronix.de/software/libsocketcan/download/
+endef
+
+define Package/libsocketcan/description
+ This package contains a library for applications dealing with CAN
sockets
+endef
+
+TARGET_CFLAGS += -ffunction-sections $(FPIC)

This is redundant, delete the line and move the $(FPIC) below...

+
+define Build/Compile
+       $(call Build/Compile/Default)
+       make -C $(PKG_BUILD_DIR) \
+               DESTDIR="$(PKG_INSTALL_DIR)" \
+               install
+endef

You can remove the entire Build/Compile override and set
PKG_INSTALL:=1 at the top, it does exactly this.

+
+TARGET_CFLAGS += \
+        -ffunction-sections \
+        -fdata-sections

Add the $(FPIC) here.

+
+CONFIGURE_VARS += \
+        ac_cv_linux_vers=$(LINUX_VERSION)
+
+MAKE_FLAGS += \
+        CCOPT="$(TARGET_CFLAGS) -I$(BUILD_DIR)/linux/include"

The include path looks bogus.

+
+
+define Build/InstallDev
+       $(INSTALL_DIR) $(1)
+       $(CP) $(PKG_INSTALL_DIR)/* $(1)/
+       mkdir -p $(1)/usr/include/libsocketcan

What is the empty directory for?

+endef
+
+define Package/libsocketcan/install
+       $(INSTALL_DIR) $(1)/usr/lib
+       $(CP) $(PKG_INSTALL_DIR)/usr/lib/libsocketcan.so.* $(1)/usr/lib/

.so.* does not include .so, is this intended?

+endef
+
+$(eval $(call BuildPackage,libsocketcan))

~ Jow
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk/6yg0ACgkQdputYINPTPPTewCfTdBFfY2p0RV41KD03Jw/Zj3x
XaIAoJYSkcf1qq2Mf9xHQvvVNxjJVda+
=ep96
-----END PGP SIGNATURE-----
_______________________________________________
openwrt-devel mailing list
[email protected]
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to