-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

> I see. The existing feeds/packages/net/nginx/Makefile already lists
>  the files under /etc/nginx that ship in the package in its
> conffiles definition, but this doesn't result in a keep file in the
> package because include/package-ipkg.mk will only add entries to a
> keep file when they aren't present as files in the package.

... or when the entry is a directory.

But they will get recorded by opkg, which is another source sysupgrade
uses to assemble the list of files to get backed up.

The sysupgrade list is the distinct union of

find -type f $(cat /etc/sysupgrade.conf)
find -type f $(cat /lib/upgrade/keep.d/*)
opkg list-changed-conffiles

> Is this intentional?

Yey.

> The net effect is that changes to conffiles aren't preserved across
>  sysupgrade when default conffiles are present in a package.

Huh?

> If that's the case, what's the point of even listing these files in
>  conffiles?

The point is:

- - Existing file entries in conffiles are tracked by opkg, and
  opkg list-changed-conffiles is used to only back up actually modified
  configs during a sysupgrade

- - Directory or not existing file entries are added to the keep list so
  that they're unconditionally backed up during sysupgrade

I agree that adding /etc/nginx will overrule the opkg tracking (means
files are *always* backed up, even if unchanged, but that is such a
minor problem that neither needs fixing nor much discussion about.

In any case, simply add /etc/nginx/ to conffiles, it will work as
intended and you do not need to ship a custom keep file.

~ Jow
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAlA3d/cACgkQdputYINPTPMmdwCfZcvNtg1ogFC2W4haYjYEv4lI
5N0An3egffwxDtaXlo6/1c50OJW/CoZT
=BxMq
-----END PGP SIGNATURE-----
_______________________________________________
openwrt-devel mailing list
openwrt-devel@lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel

Reply via email to